-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement views, routes and worker for RoninVulns
#64
Implement views, routes and worker for RoninVulns
#64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising! Just needs specs. Not sure if you wanted to add additional Advanced Options in this PR or another PR?
I definitely want to add Advanced Options in this PR. |
I created some issues that will allow importing |
@AI-Mozi OK, this should be unblocked now. I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few things. We can use dry-types
Enum types to further lock-down the values and map the form params to proper keyword arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few HTML things. Last review, I promise.
#34 #35 #36