Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement views, routes and worker for RoninVulns #64

Merged
merged 18 commits into from
Dec 4, 2023

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Nov 7, 2023

Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising! Just needs specs. Not sure if you wanted to add additional Advanced Options in this PR or another PR?

lib/ronin/app/validations/vulns_params.rb Show resolved Hide resolved
app.rb Show resolved Hide resolved
workers/vulns.rb Show resolved Hide resolved
views/vulns.erb Outdated Show resolved Hide resolved
@moozzi
Copy link
Member Author

moozzi commented Nov 8, 2023

I definitely want to add Advanced Options in this PR.
When my PR is a draft, its not fully completed yet 😄

@postmodern
Copy link
Member

I created some issues that will allow importing Ronin::Vulns::WebVuln objects into the database:

@postmodern
Copy link
Member

postmodern commented Nov 29, 2023

@AI-Mozi OK, this should be unblocked now. I added a Ronin::Vulns::Importer module to ronin-vulns 0.2.0 branch.

Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few things. We can use dry-types Enum types to further lock-down the values and map the form params to proper keyword arguments.

lib/ronin/app/validations/vulns_params.rb Outdated Show resolved Hide resolved
lib/ronin/app/validations/vulns_params.rb Outdated Show resolved Hide resolved
lib/ronin/app/validations/vulns_params.rb Outdated Show resolved Hide resolved
lib/ronin/app/validations/vulns_params.rb Outdated Show resolved Hide resolved
lib/ronin/app/validations/vulns_params.rb Outdated Show resolved Hide resolved
workers/vulns.rb Outdated Show resolved Hide resolved
workers/vulns.rb Outdated Show resolved Hide resolved
workers/vulns.rb Outdated Show resolved Hide resolved
workers/vulns.rb Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@moozzi moozzi marked this pull request as ready for review December 1, 2023 12:11
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few HTML things. Last review, I promise.

views/db/vulns/index.erb Outdated Show resolved Hide resolved
views/vulns.erb Outdated Show resolved Hide resolved
views/vulns.erb Outdated Show resolved Hide resolved
views/vulns.erb Outdated Show resolved Hide resolved
views/vulns.erb Outdated Show resolved Hide resolved
views/vulns.erb Outdated Show resolved Hide resolved
views/db/vulns/show.erb Show resolved Hide resolved
@postmodern postmodern merged commit cb7ab95 into ronin-rb:main Dec 4, 2023
3 of 4 checks passed
@postmodern postmodern added the feature New Feature label Dec 4, 2023
@postmodern postmodern added this to the 0.1.0 milestone Dec 4, 2023
This was referenced Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants