Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputFormat#close method. #55

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Aug 30, 2024

No description provided.

@moozzi moozzi self-assigned this Aug 30, 2024
@moozzi
Copy link
Member Author

moozzi commented Aug 30, 2024

I'm wondering if it should be merged to 0.3.0 or main. Also not sure if description is descriptive enough.

@postmodern
Copy link
Member

New methods/classes should always be merged into the upcoming version branch so as not to disrupt main which should only receive bug fixes. Also add @since tags to them.

@moozzi moozzi force-pushed the add_close_to_output_format branch from 499d89f to b9731c5 Compare August 30, 2024 11:06
@postmodern postmodern added the feature New Feature label Aug 30, 2024
@postmodern postmodern added this to the 0.3.0 milestone Aug 30, 2024
@postmodern postmodern added the output-formats Output Formats label Aug 30, 2024
@postmodern postmodern merged commit 9478d68 into 0.3.0 Aug 30, 2024
14 checks passed
@postmodern postmodern self-requested a review August 30, 2024 20:51
@moozzi moozzi deleted the add_close_to_output_format branch August 31, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature output-formats Output Formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants