Add cookie kwarg to Ronin::Web::Browser::Agent initializer #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieWWW94
force-pushed
the
add-cookie-kwarg
branch
from
14caa82 to
22a4de6
Compare
postmodern
approved these changes
Jul 26, 2024
|
Great idea. Singular makes sense for when you want to quickly initializing a single session cookie. I think we could also add |
@postmodern If there are further features you would like added (such as the above) please let me know, or open some issues. Would be glad to work through them. |
|
@CharlieWWW94 see #22 and #23. Issue #23 will help with implementing #17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #17 by adding a cookie kwarg to set after browser initialization. Went with the singular
cookieas the description of the issue suggested this would be used for the session cookie. Just let me know if this should support an array of cookies to set or, of course, if any other changes are required.