Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Update actions/checkout to v4 #172

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

Sushrut1101
Copy link
Contributor

No description provided.

@postmodern postmodern merged commit df41a33 into ronin-rb:main Oct 1, 2023
5 checks passed
@postmodern postmodern added the chore You gotta do, what you gotta do label Oct 1, 2023
@postmodern
Copy link
Member

postmodern commented Oct 1, 2023

Are you participating in hacktoberfest? Should I tag this as a hacktoberfest PR?

@postmodern
Copy link
Member

I may have merged too quickly, looks like you missed a spot:
fb8b58f#diff-ce0dee93a528f6c7648f4cd671a3ec7be6a80f976c88f3aa1c322b7a80828fbaR38

@postmodern
Copy link
Member

I took care of updating the other repositories.

@Sushrut1101
Copy link
Contributor Author

Are you participating in hacktoberfest? Should I tag this as a hacktoberfest PR?

Yeah! 😃

@postmodern
Copy link
Member

@Sushrut1101 feel free to update the other actions/checkout@v2 at the bottom.

@postmodern postmodern added the hacktoberfest Hacktoberfest label Oct 2, 2023
@Sushrut1101
Copy link
Contributor Author

@Sushrut1101 feel free to update the other actions/checkout@v2 at the bottom.

Sure!

Btw, I think you'll need to add the hacktoberfest-accepted label instead, because it's still showing not participating in the hacktoberfest page

@postmodern
Copy link
Member

postmodern commented Oct 2, 2023

@Sushrut1101 looks like someone beat you to it.

According to the rules for participating in Hacktoberfest, the repo is already tagged with hacktoberfest so any accepted PR will count.

Also, looking at your GitHub activity, you appear to be sending a lot of PRs that jump bump the actions/checkout@v version. The hacktoberfest organizers might consider that activity as spamming or low-effort PRs.

@Sushrut1101
Copy link
Contributor Author

@Sushrut1101 looks like someone beat you to it.

According to the rules for participating in Hacktoberfest, the repo is already tagged with hacktoberfest so any accepted PR will count.

Also, looking at your GitHub activity, you appear to be sending a lot of PRs that jump bump the actions/checkout@v version. The hacktoberfest organizers might consider that activity as spamming or low-effort PRs.

Nope, this repository only seems to have the following labels:
ruby cli console security orm database hacking infosec network-tools ctf-tools security-tools ronin ronin-rb ctf-tool
The message that I'm getting on the hacktoberfest page is:
Your PR/MR was submitted to a repository that is not participating in Hacktoberfest. Maintainers need to add the hacktoberfest topic to the repository, or add the hacktoberfest-accepted label to your PR/MR. For more information about how exactly we validate PR/MRs for contributors, check the details on our participation page.
Repo Tags

@postmodern
Copy link
Member

@Sushrut1101 added the hacktoberfest topic to the repo.

@postmodern
Copy link
Member

Hacktoberfest 2023 is now over! Congratulations on successfully submitting a PR to Ronin. As mentioned in the blog post, you are now eligible for free Ronin stickers! In order to claim your free stickers, please join the Ronin Discord server, and DM me the following information:

  1. Which stickers do you want?
  2. Your full mailing address.

The stickers will then be mailed in a regular flat-rate envelope, from the US, without tracking. Note, it may take up to one month for International mail to arrive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore You gotta do, what you gotta do hacktoberfest Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants