Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for HttpListener in Ronin::CLI::Commands::New #252: #255

Closed
wants to merge 4 commits into from
Closed

Add spec for HttpListener in Ronin::CLI::Commands::New #252: #255

wants to merge 4 commits into from

Conversation

raj921
Copy link
Contributor

@raj921 raj921 commented Dec 9, 2024

Added a spec for the HttpListener command to confirm its name is set to 'http-listener'.

raj921 added 4 commits December 8, 2024 15:52
@raj921
Add more basic pattern options to CLI::PatternOptions
8654a4d 
Added new pattern options:
- --alpha: /[a-zA-Z]+/
- --uppercase: /[A-Z]+/
- --lowercase: /[a-z]+/
- --alpha-numeric: /[0-9a-zA-Z]+/
- --hex: /[0-9a-fA-F]+/
- --uppercase-hex: /[0-9A-F]+/
- --lowercase-hex: /[0-9a-f]+/

Resolves ronin-rb#253
@raj921
Add spec for CLI::Commands::New::Exploit (issue ronin-rb#252)
c6c12e2 
Added a basic spec file that verifies the command_name matches
the file name for the Exploit command class.
@raj921
Fix pattern options to use blocks instead of value
4a20559 
Replaced value: {...} with blocks that set @pattern to the respective
Regexp for all pattern options. This maintains the existing behavior
where options set @pattern directly rather than accepting a value.
@raj921
Added spec for CLI::Commands::New::HttpListener (issue ronin-rb#252)
98e1606
postmodern
postmodern requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a separate PR. You should be able to git cherry-pick the commit out into a separate branch and submit another PR for it.

@raj921
Copy link
Contributor Author

raj921 commented Dec 9, 2024

sorry sir my bad i will close make a new pr

postmodern
postmodern requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears some other commits got into the PR. You should be able to remove the other commits by doing a git rebase -i main and changing pick to drop on the unwanted commits. Or I could try using git cherry-pick to only pull in the last commit from your branch?

@raj921 raj921 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern requested changes

Assignees

@raj921 raj921

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raj921 @postmodern