Merge pull request #72 from ropensci/devel

Increase test coverage, includes update_station_list()
ropensci · Sep 4, 2019 · b137503 · b137503
2 parents 50eefc0 + f53c9a5
commit b137503
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 4 deletions.
diff --git a/R/GSODR-package.R b/R/GSODR-package.R
@@ -31,7 +31,7 @@
 #'
 #' @name GSODR
 #'
-#' @author Adam Sparks, Tomislav Hengl and Andrew Nelson
+#' @author Adam H. Sparks, Tomislav Hengl and Andrew Nelson
 #'
 #' @seealso
 #'
@@ -54,7 +54,7 @@
 #'
 #' \strong{Useful links:}
 #' \itemize{
-#' \item{Static documentation at \url{https://ropensci.github.io/GSODR/}}
+#' \item{Static documentation at \url{https://docs.ropensci.org/GSODR/}}
 #' \item{Development repository at \url{https://github.com/ropensci/GSODR}}
 #' \item{Report bugs at \url{https://github.com/ropensci/GSODR/issues}}
 #' }

diff --git a/man/GSODR.Rd b/man/GSODR.Rd
diff --git a/tests/testthat/test-update_station_list.R b/tests/testthat/test-update_station_list.R
@@ -10,3 +10,34 @@ test_that("If user selects no, database not updated", {
   options(GSODR_connection = stdin())
   close(f)
 })
+
+# update_forecast_locations() d-loads, imports file and resets timeout on exit--
+test_that("update_station_list() downloads and imports proper file", {
+  skip_on_cran()
+  f <- file()
+  options(GSODR_connection = f)
+  ans <- "yes"
+  write(ans, f)
+  expect_message(update_station_list())
+  load(system.file("extdata", "isd_history.rda", package = "GSODR"))
+  expect_equal(ncol(isd_history), 11)
+  expect_named(
+    isd_history,
+    c(
+      "STNID",
+      "NAME",
+      "LAT",
+      "LON",
+      "CTRY",
+      "STATE",
+      "BEGIN",
+      "END",
+      "COUNTRY_NAME",
+      "ISO2C",
+      "ISO3C"
+    )
+  )
+  expect_equal(options("timeout")[[1]], 60)
+  options(GSODR_connection = stdin())
+  close(f)
+})