Skip to content

Commit

Permalink
Fix issues in DESCRIPTION as asked by CRAN
Browse files Browse the repository at this point in the history
Spelling out abbreviations for CSV and GIS and adding sinqle quotes
around ‘getGSOD.R’ from T. Hengl.
  • Loading branch information
adamhsparks committed Apr 20, 2016
1 parent 904dad4 commit cc20feb
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 20 deletions.
31 changes: 16 additions & 15 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,22 @@ Description: Download, clean and reformat weather data from USA National
defined by the user, to assure data quality. Stations with too many missing
observations are omitted from final file. Also omitted are stations with a
latitude of < -90 or > 90 or longitude of < - 180 or > 180. Output is
returned as a .csv file, written to disk in a location selected by the user,
which summarises each year by station and includes new variables: actual and
saturation vapor pressure and relative humidity calculated from the original
GSOD data. The resulting files can be as large as 500mb depending on the
users stringency for missing data and geographic area of interest. Be sure
to have sufficient RAM and disk space as well as a reasonably fast internet
connection to use this package to perform this operation. However, for much
smaller and more manageable data sets, an individual country of interest may
be selected as well as only stations falling between -60/60 degrees latitude
for agroclimatology work (this is the default behaviour). The output .csv
files include station data (e.g., station name, country, latitude,
longitude, elevation) for use in a GIS. The function was largely based on T.
Hengl's "getGSOD.R" script, available from
<http://spatial-analyst.net/book/system/files/getGSOD.R> with
enhancements to be more cross-platform, faster and a bit more flexible.
returned as a comma-separated values (CSV) file written to disk in a
location selected by the user, which summarises each year by station and
includes new variables: actual and saturation vapor pressure and relative
humidity calculated from the original GSOD data. The resulting files can be
as large as 500mb depending on the user's stringency for missing data and
geographic area of interest. Be sure to have sufficient RAM and disk space
as well as a reasonably fast internet connection to use this package to
perform this operation. However, for much smaller and more manageable data
sets, an individual country of interest may be selected as well as only
stations falling between -60/60 degrees latitude for agroclimatology work.
The resulting files include station data (e.g., station name, country,
latitude, longitude, elevation) for use in a geographic information system
(GIS). The function was largely based on T. Hengl's 'getGSOD.R' script,
available from
<http://spatial-analyst.net/book/system/files/getGSOD.R> with enhancements
to be more cross-platform, faster and more flexible.
Depends:
R (>= 3.0.0)
License: GPL (>= 3)
Expand Down
4 changes: 2 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
GSODR v0.1.1 (Release date: 2016-04-20)
GSODR (Release date: 2016-04-20)
==============

Changes:

* Add single quotes around possibly misspelled words and spell out comma-separated values and geographic information system rather than just using "CSV" or "GIS" in DESCRIPTION.
* Add full name of GSOD (Global Surface Summary of the Day) and URL for GSOD, https://data.noaa.gov/dataset/global-surface-summary-of-the-day-gsod to DESCRIPTION as requested by CRAN.
* Require user to specify directory for resulting .csv file output so that any files written to disk are interactive and with user's permission

Expand Down
4 changes: 1 addition & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
## Resubmission
This is a resubmission. In this version I have:

* Added the full name of GSOD (Global Surface Summary of the Day) to the DESCRIPTION file

* Modified the default behaviour of the package to stop and ask the user to specify a location in which they wish for the output file to be written
* Added single quotes, " ' ", around possibly misspelled words in the DESCRIPTION file and also spelled out "comma-separated values" (CSV) and "Geographic Information System" (GIS).

## Test environments
* local OS X install, R 3.2.4
Expand Down

0 comments on commit cc20feb

Please sign in to comment.