Use {withr} to avoid complications with changing working directory.

DESCRIPTION

@@ -53,7 +53,8 @@ Imports:
     data.table (>= 1.15.4),
     R.utils,
     stats,
-    utils
+    utils,
+    withr
 Suggests:
     bit64,
     dplyr,

NEWS.md

@@ -4,6 +4,8 @@
 
 - Enforce {data.table} >= 1.15.4 due to issue with `fifelse()` as reported in <https://github.com/ropensci/GSODR/issues/121>
 
+- Fix issue with working directory changing as reported in <https://github.com/ropensci/GSODR/issues/124#issuecomment-2342686025>
+
 # GSODR 4.1.1
 
 ## Bug fixes

R/internal_functions.R

@@ -199,13 +199,8 @@
       # create a list of files that have been downloaded and untar them
       tar_files <-
         list.files(tempdir(), pattern = "*\\.tar.gz$", full.names = TRUE)
-      for (i in tar_files) {
-        wd <- getwd()
-        on.exit(setwd(wd))
-        setwd(tempdir())
-        year_dir <- substr(i, nchar(i) - 10, nchar(i) - 7)
-        utils::untar(i, exdir = year_dir)
-      }
+
+      withr::with_dir(tempdir(), .untar_files(tar_files))
 
       GSOD_list <-
         list.files(
@@ -367,3 +362,19 @@
     )[[1]]
   ))
 }
+
+
+#' Untar GSOD Tar Archive Files
+#'
+#' @param tar_files a list of tar files located in in `tempdir()`
+#'
+#' @noRd
+#' @return called for it's side-effects, untars the archive files in the
+#'  `tempdir()`
+
+.untar_files <- function(tar_files) {
+  for (i in tar_files) {
+    year_dir <- substr(i, nchar(i) - 10, nchar(i) - 7)
+    utils::untar(i, exdir = year_dir)
+  }
+}

codemeta.json

@@ -317,12 +317,24 @@
       "identifier": "utils",
       "name": "utils"
     },
+    "8": {
+      "@type": "SoftwareApplication",
+      "identifier": "withr",
+      "name": "withr",
+      "provider": {
+        "@id": "https://cran.r-project.org",
+        "@type": "Organization",
+        "name": "Comprehensive R Archive Network (CRAN)",
+        "url": "https://cran.r-project.org"
+      },
+      "sameAs": "https://CRAN.R-project.org/package=withr"
+    },
     "SystemRequirements": null
   },
   "applicationCategory": "Tools",
   "isPartOf": "https://ropensci.org",
   "keywords": ["US-NCEI", "meteorological-data", "global-weather", "weather", "weather-data", "meteorology", "station-data", "surface-weather", "data-access", "US-NCDC", "r", "gsod", "ncdc", "weather-stations", "global-data", "ncei", "weather-information", "historical-weather", "historical-data", "daily-data", "daily-weather", "rstats", "r-package"],
-  "fileSize": "4344.975KB",
+  "fileSize": "4347.54KB",
   "citation": [
     {
       "@type": "SoftwareSourceCode",