Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes several bugs including unavailable dates and invalid geojson objects #52

Merged
merged 99 commits into from
Oct 29, 2024
Merged

Fixes several bugs including unavailable dates and invalid geojson objects #52

merged 99 commits into from
Oct 29, 2024

Conversation

adamhsparks
Copy link
Member

@adamhsparks adamhsparks commented Oct 19, 2024 •
edited
Loading

Fixes

adamhsparks and others added 30 commits August 29, 2021 21:17
@adamhsparks
Should fix NOTE when running pkg checks
749fe35
@adamhsparks
Merge branch 'master' into devel
a9b223c
@adamhsparks
Don't deploy pkgdown
e4aace4
@adamhsparks
Remove deprecated context() from tests
1cf7729
@adamhsparks
Fixes bug where only data of >3 days can be requested
800ba70
@adamhsparks
Use vcr >= 0.6.0 and update RoxygenNote
a638ad0
@adamhsparks
Remove full stop from function title
f421dab
@adamhsparks
Formatting code and documentation
c948108
@adamhsparks
Removes vcr
d76d80f
@adamhsparks
Formatting in documentation
9bbbde6
@adamhsparks
Remove vcr capabilities
016c346
@adamhsparks
update test_data.rda contents
c8c729b
@adamhsparks
remove test_data.rda from ./R
05d7aba
@adamhsparks
setup chirps to use vcr
8c87e0e
@adamhsparks
Add new cassette for get_esi tests
6daaa04
@adamhsparks
Revise tests for get_chirps (vcr still doesn't work here though?)
8870794
@adamhsparks
Update .gitattributes for vcr config
2a834ae
@adamhsparks
creates coords and geojson objects for tests
713308c
@adamhsparks
Add comment on contents of test_data.rda for clarity
87ea90c
@adamhsparks
Enhance tests for get_esi
7226cf9
@adamhsparks
Rename cassettes to follow a standard scheme
d5c564c
@adamhsparks
remove redundant lines
d2cb2d9
@adamhsparks
begin to rewrite tests for get_chirps()
b464e1d
@adamhsparks
The "sf" test on line 14 cassette is not created
8ba2fe6
@adamhsparks
More fiddling with vcr for tests
b6d5f08
@maelle
change suggestion
46c9f67
@adamhsparks
Merge pull request #34 from ropensci/maelle-patch-1
899df8b 
change suggestion
@adamhsparks
Adds fixture for CHIRPS_sf_method_return_sf
7e97538 
Thanks Maëlle Salmon!
@adamhsparks
use testthat::test_path() for loading helper data
54549eb 
Closes #33
@adamhsparks
Fix long lines
86674b4
@kauedesousa kauedesousa merged commit 951fd2f into master Oct 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kauedesousa kauedesousa Awaiting requested review from kauedesousa

Assignees

@kauedesousa kauedesousa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamhsparks @kauedesousa @maelle