Vincent review #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames to pass checks
- Remove <> from BugReports: in the DESCRIPTION file - Remove .md from LICENSE - Update shinytests2 after changing shiny UI in previous commit - grid_to_polygon dplyr::filter() changes to base R to avoid issues - Fix qk_to_latlong_function to include a column with the level of detail - extract_*_coords() functions create columns needed to avoid warning - Improvement in rowwise() implementation. Tidyselect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes most of the changes suggested by @vincentvanhees here
Please, read ropensci/software-review#619 for the full review.