-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate Jacobian Inverse #92
base: master
Are you sure you want to change the base?
Calculate Jacobian Inverse #92
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 80.20% 88.05% +7.85%
==========================================
Files 4 4
Lines 197 226 +29
Branches 35 41 +6
==========================================
+ Hits 158 199 +41
+ Misses 28 15 -13
- Partials 11 12 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Please add some unit tests to improve coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already mentioned, please consider adding some unit tests.
And I'd prefer to use the new method also in
convert_cartesian_deltas_to_joint_deltas
instead of duplicating the calculation?
…mic, 1> instead of Matrixd
…bian_inverse method
This PR introduces a method for computing the Jacobian inverse, along with a corresponding KDL implementation.