Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AsyncFunctionHandler] return execution time in nanoseconds #181

Conversation

saikishor
Copy link
Member

I think this is useful to have more statistical data when we add to the CM

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.51%. Comparing base (926f097) to head (5fe33ee).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   75.36%   75.51%   +0.14%     
==========================================
  Files           8        8              
  Lines         341      343       +2     
  Branches       54       54              
==========================================
+ Hits          257      259       +2     
  Misses         50       50              
  Partials       34       34              
Flag Coverage Δ
unittests 75.51% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/async_function_handler.hpp 91.25% <100.00%> (+0.22%) ⬆️

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is nice! Thank you

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't a nanosecond be represented in a double value of seconds? The time delta will be <1.0 -> we have ~15 digits after the comma?

@saikishor
Copy link
Member Author

Shouldn't a nanosecond be represented in a double value of seconds? The time delta will be <1.0 -> we have ~15 digits after the comma?

@christophfroehlich
Yes, but if you want to see the spikes in that 15 digits, it is not very easy. Instead, having it as nanoseconds can let you easy. This is the most granularity you can get

@christophfroehlich christophfroehlich merged commit 974c89c into ros-controls:master Oct 31, 2024
26 checks passed
@saikishor saikishor deleted the async_function_handler/nanoseconds branch October 31, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants