Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python interface for ROS features #17

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

SammyRamone
Copy link
Contributor

Closes #16

I did not implement any method for declaring parameters, as the node is accepting undeclared parameters anyway.
Otherwise, I implemented the interface straight forward. Maybe there is a better method for defining the different set_parameter() methods. I tried using boost::variant but did not get it to work and settled for the pragmatic solution. Any suggestions for doing this more cleverly are, of course, welcome.

I included a demo script which shows how the user can manually set parameters and call execute a reach study. In this case we just drastically decrease solving time to show that this leads to different (worse) results.
@sea-bass: You mentioned that you are interested in using REACH for benchmarking IKs. Maybe this could be a basis for building a Python benchmarking script.

The documentation is currently a bit limited. If you have further ideas on things that should be added, I will extend it.

@marip8
Copy link
Member

marip8 commented Jun 29, 2023

Thanks for addressing this. I'll take a look at it soon

@SammyRamone
Copy link
Contributor Author

I added one more commit to the PR which introduces a small helper method to set the logger level of C++ ROS loggers. Otherwise some plugins (especially those based on MoveIt) will generate a lot of spam info message which can be annoying.

@SammyRamone
Copy link
Contributor Author

I changed the setting of parameters due to an issue similar to ros-industrial/reach#59

@marip8
Copy link
Member

marip8 commented Aug 16, 2023

Per this comment the rolling build is broken because the ros:rolling docker image is not up-to-date. I'm going to merge as-is and let the rolling build get fixed when the rolling docker image is updated

@marip8 marip8 merged commit bd0e91a into ros-industrial:master Aug 16, 2023
4 of 5 checks passed
@marip8 marip8 mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose ROS features in Python interface
2 participants