Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable services #200

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gsalinas
Copy link

Some 402 drivers (at a minimum, the one I'm using) support designating one of their outputs as a dedicated brake output, set automatically by the 402 state machine, for use with motors with brakes.

This PR adds enable and disable services so that you can move your drive from Operational state to Switched On Disabled state; for situations where a user wants the brake engaged whenever stationary, this gives the necessary hooks to do so - verify that your motion is finished according to your situation, then call the disable service, and call enable before moving again.

Additionally, the enable service allows you to get back into an operational state without calling init, which always redoes homing even if the drive had already been homed.

Thank you!

@hellantos
Copy link
Member

@gsalinas
Looks great. We had taken the cia402 implementation from the ROS1 stack where the init recover and halt functions were the main interactions. I personally would be in favor of having more fine grained control with dedicated services as you proposed. In this case I would propose to as well add a home service.

@ipa-vsp
Copy link
Member

ipa-vsp commented Aug 20, 2024

@gsalinas could you please fix the pre-commit

@gsalinas
Copy link
Author

@ipa-vsp Apologies - this fell off my radar! Fixed now!

@danzimmerman
Copy link

danzimmerman commented Dec 7, 2024

In this case I would propose to as well add a home service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants