Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable CRF? #30

Closed
tonynajjar opened this issue May 7, 2024 · 4 comments
Closed

Configurable CRF? #30

tonynajjar opened this issue May 7, 2024 · 4 comments

Comments

@tonynajjar
Copy link

CRF is the first configuration point in the website but doesn't seem configurable. Any good reason or just not implemented?

@berndpfrommer
Copy link
Collaborator

I wasn't aware of CRF, if that qualifies as a good reason. I don't see any CRF setting in the AVCodecContext struct. Way back when I wrote the first version of this I got to where I wanted by tuning "qmax". Be happy to see a PR to add a knob for CRF.

@tonynajjar
Copy link
Author

tonynajjar commented May 7, 2024

I see it here which is version 0.6. Your points to "trunk", not sure what that is. I think it was removed in later versions... not sure why or where it was added instead

@tonynajjar
Copy link
Author

I searched for a bit and really don't see an obvious way to do this. I guess I'll content myself with other knobs for the time being

@shtern
Copy link
Contributor

shtern commented Nov 4, 2024

Fixed in #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants