Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isaacsim pip with cache pkgs #44305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

baconbrot
Copy link
Contributor

@baconbrot baconbrot commented Jan 29, 2025

Please add the following dependency to the rosdep database.

Package name:

Edit: In the newly released Isaac Sim 4.5.0, the package structure has changed. Packages are now installed via pip extras, and I propose adding the following extras to rosdep to replace the old ones:

python3-isaacsim-all-pip
python3-isaacsim-rl-pip
python3-isaacsim-ros-pip
python3-isaacsim-ros2-pip
python3-isaacsim-extscache-pip

python3-isaacsim-pip
python3-isaacsim-extscache-physics-pip
python3-isaacsim-extscache-kit-pip
python3-isaacsim-extscache-kit-sdk-pip

Package Upstream Source:

NA

Purpose of using this:

Simulating ROS integrated robots using NVIDIA Omniverse IsaacSim.
The main package isaacsim can be supplemented by any subset of the other three cache packages to accelerate first time startup.

Links to Distribution Packages

There are no special distribution packages, only pip.
pip:

Edit: Available extras can be inspected in the isaacsim-4.5.0.0.tar.gz file available on PyPI.

Additional notes

Installation with rosdep might require the user to set the --as-root pip:false flag, e.g.
rosdep install -i -y --from-paths src --as-root pip:false

@baconbrot baconbrot requested a review from a team as a code owner January 29, 2025 17:47
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jan 29, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@baconbrot
Copy link
Contributor Author

This package is currently only available for python 3.10. Should the pip install be restricted to e.g. Ubuntu jammy (which has default python version 3.10.X)?

@baconbrot baconbrot marked this pull request as draft February 2, 2025 21:00
@baconbrot
Copy link
Contributor Author

baconbrot commented Feb 2, 2025

IsaacSim 4.5.0 was released during this PR.

The new version replaces isaacsim with isaacsim[all].
Since pip extras aren't supported yet (see ros-infrastructure/rosdep#900), I'll manually add each extra from isaacsim including the corresponding packages to python3-isaacsim-<extra>-pip, similar to how python-pytorch-pip installs both pytorch and torchvision.

@baconbrot baconbrot marked this pull request as ready for review February 2, 2025 22:46
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant