-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visualization team and a release repository. #455
Conversation
The repository has been mirrored into ros2-gbp here: ros2-gbp/ros2-gbp-github-org#455 I did not change the release repository for noetic at this time since it is not required for ROS 1 distributions, but if the maintainer prefers to use a single release repository for all distributions that is perfectly acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment inline, but I'll still approve and leave it to @nuclearsandwich whether to change it or not.
@@ -184,6 +184,7 @@ locals { | |||
local.vision_opencv_team, | |||
local.vision_team, | |||
local.visp_team, | |||
local.visualization_team, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it is worth, I'm not a huge fan of calling this team visualization_team
. There are a lot of repositories in https://github.com/ros-visualization, and the members of this team aren't necessarily the maintainers of all of these repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette any suggestion of another name would have been acceptable to me. In the absence of one, I'm going to merge as is but these team names don't propagate out of here so it's perfectly fine to change them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that's fair. I can open a PR to rename this.
The mirrored repository was manually imported before terraform deployment with
|
This change has been deployed! |
No description provided.