use Visual Studio 2017

[dirk-thomas]

Using VS 2017 requires the following:

• Visual Studio 2017
• Connext 5.3.0.1 for VS2017
• OpenCV for VS2017 (patched as followed)
  I had to patch the OpenCV archive:
  • The old CMake config file checked for:

    elseif(MSVC_VERSION EQUAL 1910)
    

  • but according to the CMake docs
    (https://cmake.org/cmake/help/latest/variable/MSVC_VERSION.html) it needs to be since the current VS2017 version identifies itself as 1912:

    elseif(MSVC_VERSION GREATER_EQUAL 1910 AND MSVC_VERSION LESS_EQUAL 1919)
    

• rebase upstream master ament/googletest#1 to avoid compiler warnings

All active Windows nodes have been updated accordingly (in parallel to the VS2015 stuff).

• 
  • I shortend the job name since otherwise the commands exceed the maximum length in Windows since the VS2017 path is longer than the VS2015 path.

Before we can switch:

• the Connext binaries for VS2017 must be publically available via https://www.rti.com/downloads/connext-files.
• the following upstream bugs have to be addressed to avoid compiler warnings:
  • compiler warnings with Visual Studio 2017 due to gtest ros/console_bridge#51
  • compiler warnings with Visual Studio 2017 due to gtest ros/urdfdom#107, gtest: new version to fix warnings urdfdom#9
  • compiler warnings with Visual Studio 2017 rviz#184

After the switch we need to update the wiki with a note that the latest release uses VS2015 and the default branches use VS2017.

Fixes ros2/build_farmer#69.

[mikaelarguedas]

@dirk-thomas will it be possible to keep building with connext 5.3.0 VS2015 and VS2015 once this is merged ? (we will likely need it for ardent patch releases)

(probably) good news: this should allow us to update the python version on the windows machines 🎉 , as last time we tried to build python3.6.4 it failed because it needs SDK 10.0.

To keep in mind: The new SDK introduces new defines that may collide with the defines used in some of our messages (several of them in 8.1 already collide, for example: DELETE or NO_ERROR)

[dirk-thomas]

will it be possible to keep building with connext 5.3.0 VS2015 and VS2015 once this is merged ? (we will likely need it for ardent patch releases)

After this is merged using Visual Studio 2015 will require a custom branch in this repo which basically reverts the changes from this PR.

[dirk-thomas]

The ETA for the GA of Connext 5.3.1 (which will support VS2017) is end of Q1 2018.

[nuclearsandwich]

With the Connext ETA in mind, are we targeting VS2017 for Bouncy?

[dirk-thomas]

are we targeting VS2017 for Bouncy?

Yes.

[dirk-thomas]

Rolled into #146.