[rclpy_examples] QoS examples #132
Conversation
| parser = argparse.ArgumentParser(formatter_class=argparse.ArgumentDefaultsHelpFormatter) | ||
| parser.add_argument( | ||
| '-r', '--reliability', type=int, default=0, choices=[0, 1], | ||
| help='0: reliable, 1: best effort') |
There was a problem hiding this comment.
When being called reliability I would expect the value 1 to actually be reliable.
There was a problem hiding this comment.
thanks for pointing it out, fixed in 1ce6239
| parser = argparse.ArgumentParser(formatter_class=argparse.ArgumentDefaultsHelpFormatter) | ||
| parser.add_argument( | ||
| '-r', '--reliability', type=int, default=0, choices=[0, 1], | ||
| help='1: reliable, 0: best effort') |
There was a problem hiding this comment.
Are there any other options planned? If not I would suggest using a boolean flag --reliable instead.
There was a problem hiding this comment.
I hesitated to add other profiles that's why I settled for a integer parameter. Given that this is supposed to be an example I think we can keep it simple and restrict ourselves to only 2 qos profiles.
|
Does it make sense to create new scripts rather then extending the already existing ones? |
|
I see your point, this comes down to how simple do we want the examples to be, should the basic pub/sub examples expose how to configure the Quality of Service? or does it make sense to have another script showing how to handle QoS on top of the basic example? |
|
thanks |
|
If nobody has strong opinions about #132 (comment) I'm going to merge this as is |
|
Sure, go ahead with the merge. |
Add reliable/best effort talker listener example