Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron Backport of #720 #724

Closed

Conversation

CursedRock17
Copy link
Contributor

Iron "Backport" of #720 in which we added .hpp versions of the .h files in tf2, but without the warning message to get backwards compatibility and prevent weird syntax like this:

#if __has_include(<cv_bridge/cv_bridge.hpp>)
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
#else
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
#endif

Signed-off-by: CursedRock17 <[email protected]>

Iron Backport of ros2#720

Signed-off-by: CursedRock17 <[email protected]>
Signed-off-by: CursedRock17 <[email protected]>

Update Matrix3x3.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Matrix3x3.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update MinMax.h

Signed-off-by: Lucas Wendland <[email protected]>

Update MinMax.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update QuadWord.h

Signed-off-by: Lucas Wendland <[email protected]>

Update QuadWord.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Quaternion.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Quaternion.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Scalar.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Scalar.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Transform.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Transform.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Vector3.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Vector3.hpp

Signed-off-by: Lucas Wendland <[email protected]>
@CursedRock17 CursedRock17 force-pushed the deprecate_tf2_headers_iron branch from c0acd59 to abc3043 Compare November 8, 2024 06:46
Signed-off-by: CursedRock17 <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 18, 2024

iron is EOL, closing this one

@ahcorde ahcorde closed this Dec 18, 2024
@CursedRock17 CursedRock17 deleted the deprecate_tf2_headers_iron branch January 17, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants