Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rosdep: 1) Friendlier to beginners, 2) Clarifying rosdep is ROS-agnostic #3719

Merged
merged 11 commits into from
Aug 4, 2023
Merged

Improve rosdep: 1) Friendlier to beginners, 2) Clarifying rosdep is ROS-agnostic #3719

merged 11 commits into from
Aug 4, 2023

Commits on Aug 4, 2023

  1. Improve: rosdep 

    - Avoid giving an impression that `rosdep` is ros-dependent. It is actually widely applicable than ROS projects.
   - This matters IMO where the development involves non-ROS environment e.g. corporate, where people tend to end up inventing their own dependency management framework that runs alongside of `rosdep`, resulted in `rosdep` not being contributed.
- Trying to make it friendlier to non-expert readers by clarifyig `rosdistro` website and some jargons.
- Explanation of `<*depend>` is missing in ros2 doc set. Something detailed like http://docs.ros.org/en/melodic/api/catkin/html/howto/format2/catkin_library_dependencies.html
   - Thought I'd add those in here but ran out of time. I don't know if rosdep page is the best for such info anyways.
    @130s @clalancette
    130s authored and clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    764cfd8 View commit details
    Browse the repository at this point in the history

  2. Improve: rosdep: Add link to detail about the types of dependency

    @130s @clalancette
    130s authored and clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7d46c42 View commit details
    Browse the repository at this point in the history

  3. Applying review comment: source/Tutorials/Intermediate/Rosdep.rst 

    Co-authored-by: Tomoya Fujita <[email protected]>
    @130s @fujitatomoya @clalancette
    2 people authored and clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    38b21ec View commit details
    Browse the repository at this point in the history

  4. rosdep: Apply suggestions from code review 

    Co-authored-by: Chris Lalancette <[email protected]>
    @130s @clalancette
    130s and clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    28d3971 View commit details
    Browse the repository at this point in the history

  5. rosdep: Apply discussion among reviewers

    @130s @clalancette
    130s authored and clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    cd498e1 View commit details
    Browse the repository at this point in the history

  6. Add a dependency section, moved rosdep into it.

    @130s @clalancette
    130s authored and clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a3b3b9f View commit details
    Browse the repository at this point in the history

  7. Dependency: Add detail about defining deps in package.xml, CMakeLists… 

    ….txt
    @130s @clalancette
    130s authored and clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    86bdf1e View commit details
    Browse the repository at this point in the history

  8. Fixes so everything is in the toctree. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9599dd5 View commit details
    Browse the repository at this point in the history

  9. Fixes from review. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b339981 View commit details
    Browse the repository at this point in the history

  10. Feedback from review. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    10f08b1 View commit details
    Browse the repository at this point in the history

  11. Add in a link to the rosdep documentation. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4fbf3dd View commit details
    Browse the repository at this point in the history