Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UpstreamPackages to docs.ros.org documentation #3824

Merged
merged 15 commits into from
Sep 26, 2023
Merged

Add UpstreamPackages to docs.ros.org documentation #3824

merged 15 commits into from
Sep 26, 2023

Conversation

tfoote
Copy link
Contributor

@tfoote tfoote commented Aug 8, 2023

fujitatomoya
fujitatomoya reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfoote minor nitpicks.

source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated
Comment on lines 504 to 505


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those lines are not necessary.

source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
source/The-ROS2-Project/Contributing/Developer-Guide.rst
~~~~~~~~~~~~~~~~~~~~~
We strongly recommend against mixing ROS packages from upstream Debian/Ubuntu and from packages.ros.org on the same system.
In some cases such a mixed system will work correctly, but there can be negative interactions between the two sets of packages.
We’re working with Jochen and friends to minimize the chance of problems via documentation and package conflict specifications, but we expect some risks to remain, including some fairly subtle issues.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still work in progress? if not, we can delete this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly stable, but there's always going to be a bit of a push and pull as things slowly evolve.

clalancette
clalancette reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'm a bit confused by this addition. My understanding was that the ROS packages in upstream Debian/Ubuntu were ROS 1 packages, not ROS 2 ones. In point of fact, the text below even explicitly mentions that.

Given that this is the ROS 2 documentation, it doesn't make sense to me to have this here. But I'm willing to hear other opinions.

@tfoote
Copy link
Contributor Author

tfoote commented Sep 13, 2023

ROS 2 users can still get caught off guard by our boostrap dependencies up to ament already are an issue. I've edited it to show that more explicitly. And I expect that over time there will be more and more in upstream.

@clalancette
Copy link
Contributor

ROS 2 users can still get caught off guard by our boostrap dependencies up to ament already are an issue. I've edited it to show that more explicitly. And I expect that over time there will be more and more in upstream.

OK, I can get behind that bit. But there is still a lot of reference to ROS 1 in here, which doesn't seem appropriate. I'm going to go ahead and suggest some edits to remove that.

@tfoote
Copy link
Contributor Author

tfoote commented Sep 14, 2023

Thanks for the suggestions merged and fixed CI

clalancette
clalancette requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, a final set of changes after reading through it. Once these are fixed I'm happy with this change.

source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
source/The-ROS2-Project/Contributing/Developer-Guide.rst Outdated Show resolved Hide resolved
@tfoote
Copy link
Contributor Author

tfoote commented Sep 26, 2023

Changes merged and one quick update to add the upstream ROS 2 package list link. in 2e62c95

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 26, 2023
@clalancette
Minor formatting fixes.
d483a1f 
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
clalancette approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a couple of minor formatting fixes. This now looks good to me, thanks for iterating.

@clalancette clalancette merged commit b58ed0d into rolling Sep 26, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tfoote-upstream-packages branch September 26, 2023 12:44
mergify bot pushed a commit that referenced this pull request Sep 26, 2023
@tfoote @mergify
Add UpstreamPackages to docs.ros.org documentation (#3824)
b7d3def 
* Add UpstreamPackages to docs.ros.org documentation

Copying from: http://wiki.ros.org/UpstreamPackages

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit b58ed0d)
mergify bot pushed a commit that referenced this pull request Sep 26, 2023
@tfoote @mergify
Add UpstreamPackages to docs.ros.org documentation (#3824)
26c2aed 
* Add UpstreamPackages to docs.ros.org documentation

Copying from: http://wiki.ros.org/UpstreamPackages

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit b58ed0d)
This was referenced Sep 26, 2023
Merged
Merged
clalancette pushed a commit that referenced this pull request Sep 26, 2023
@mergify @tfoote
Add UpstreamPackages to docs.ros.org documentation (#3824) (#3936)
ae4c641 
* Add UpstreamPackages to docs.ros.org documentation

Copying from: http://wiki.ros.org/UpstreamPackages

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit b58ed0d)

Co-authored-by: Tully Foote <[email protected]>
clalancette pushed a commit that referenced this pull request Sep 26, 2023
@mergify @tfoote
Add UpstreamPackages to docs.ros.org documentation (#3824) (#3937)
ef3f595 
* Add UpstreamPackages to docs.ros.org documentation

Copying from: http://wiki.ros.org/UpstreamPackages

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit b58ed0d)

Co-authored-by: Tully Foote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfoote @clalancette @fujitatomoya