Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROS Resources on Docs Index #3825

Merged
merged 7 commits into from
Aug 11, 2023
Merged

Update ROS Resources on Docs Index #3825

merged 7 commits into from
Aug 11, 2023

Conversation

kscottz
Copy link
Collaborator

@kscottz kscottz commented Aug 10, 2023

This pull requests

  • Adds ROS Discord, the ROS community calendars, ROS Vimeo channel and a few other resources to the wiki index page.
  • Adds a miscellaneous section to the index that includes trademark and citation information.
  • Lists ROS Answers as deprecated
  • Updates a reference to refer to Stack Exchange, not ROS Answers.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely subjective, but the addition of all of this stuff on the front page makes it seem overwhelming to me. There are just so many links to different things here that it feels like a newcomer might get put off (this is kind of also a problem with the current page, but less so).

One idea: what if we moved most of this into the front page of "The ROS 2 Project", and then just had a link from the front page to there? At least it will be a bit more hidden and won't scare people away.

All of that said, if other maintainers think this is valuable to have on the front page, or have other ideas, I can be persuaded.

@kscottz
Copy link
Collaborator Author

kscottz commented Aug 10, 2023

I do agree that the list is a bit long. Can I offer a counter proposal to reorganize it into a series of smaller lists?

The intent here is to make sure the resources we have are easily found and up front. I think burying them deeper in the docs makes them more difficult to find.

@kscottz
Copy link
Collaborator Author

kscottz commented Aug 10, 2023

@clalancette I combined a few similar items and re-organized the lists. Take a look.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better, thanks. I've left a handful of things to consider changing.

source/index.rst Outdated Show resolved Hide resolved
source/index.rst Show resolved Hide resolved
source/index.rst Show resolved Hide resolved
source/index.rst Show resolved Hide resolved
source/index.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one additional comment, but it really isn't blocking. This looks good to me now; @kscottz I'll let you merge it (and backport it) when you are ready.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Aug 11, 2023
@kscottz kscottz merged commit 3358c49 into rolling Aug 11, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the update_resources branch August 11, 2023 16:48
mergify bot pushed a commit that referenced this pull request Aug 11, 2023
* Update front page of docs to include more community resources, deprecate answers.

* Clean up fussy RST.

* Fix bad ref.

* Fussy whitespace nitpick.

* Reorganize and clarify.

* Changes to wording.

* remove prerelease.

(cherry picked from commit 3358c49)
mergify bot pushed a commit that referenced this pull request Aug 11, 2023
* Update front page of docs to include more community resources, deprecate answers.

* Clean up fussy RST.

* Fix bad ref.

* Fussy whitespace nitpick.

* Reorganize and clarify.

* Changes to wording.

* remove prerelease.

(cherry picked from commit 3358c49)
clalancette pushed a commit that referenced this pull request Aug 21, 2023
* Update front page of docs to include more community resources, deprecate answers.

* Clean up fussy RST.

* Fix bad ref.

* Fussy whitespace nitpick.

* Reorganize and clarify.

* Changes to wording.

* remove prerelease.

(cherry picked from commit 3358c49)

Co-authored-by: Katherine Scott <[email protected]>
clalancette pushed a commit that referenced this pull request Aug 21, 2023
* Update front page of docs to include more community resources, deprecate answers.

* Clean up fussy RST.

* Fix bad ref.

* Fussy whitespace nitpick.

* Reorganize and clarify.

* Changes to wording.

* remove prerelease.

(cherry picked from commit 3358c49)

Co-authored-by: Katherine Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants