Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correct server root path SanityCheck.php #598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gerasart
Copy link
Contributor

we got issue where server root path has inccorect folder like

.../ca/site

but need that detect real root path like

../ca

and comaprison then works inccorect here

if (!(strpos($input, $beginsWith) === 0)) {

because - $input - correct symlink path
root project path - $beginsWith - incorrect.

please check on your side, my changes should works for all.

we got issue where server root path has inccorect folder like

.../ca/site

but need that detect real root path like

../ca

and comaprison then works inccorect here 

if (!(strpos($input, $beginsWith) === 0)) {

because - $input - correct symlink path
root project path - $beginsWith - incorrect.

please check on your side, my changes should works for all.
@gerasart
Copy link
Contributor Author

or maybe we need add some custom filter, that we can change it from extened plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant