Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style update suggestions #5

Merged
merged 2 commits into from
Dec 1, 2023
Merged

style update suggestions #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b04de
style update suggestions
kecnry Dec 1, 2023
5b6e639
Update jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue
kecnry Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jdaviz/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ a:active {
border-color: hsla(0,0%,100%,.35) !important;
}

.no-hint .v-text-field__details {
.no-hint .v-text-field__details, .no-hint .v-messages {
display: none !important;
}

Expand Down
19 changes: 9 additions & 10 deletions jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,37 +35,36 @@
></v-text-field>
</v-row>

<v-div v-if="n_moment > 0 && dataset_spectral_unit !== ''">
<div v-if="n_moment > 0 && dataset_spectral_unit !== ''">
<v-row>
<v-radio-group
label="Output Units"
hint="Choose whether calculated moment is in units of wavelength or velocity."
v-model="output_unit_selected"
column>
row
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did want this as column so that the options stay stacked under the heading no matter what width the tray is. With this the heading+choices wrap, which I don't like:

Screen.Recording.2023-12-01.at.9.41.08.AM.mov

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I guess that just doesn't happen for links control with shorter strings. Someday we can force the heading on its own line and stack them, but I don't think its necessary for now.

kecnry marked this conversation as resolved.
Show resolved Hide resolved
class="no-hint">
<v-radio
v-for="item in output_unit_items"
:key="item.label"
:label="item.label"
:value="item.label"
></v-radio>
</v-radio-group>
</v-row>
<v-row v-if="output_unit_selected === 'Velocity'" align="center">
<v-col cols="9">
</v-row>
<v-row v-if="output_unit_selected === 'Velocity'">
<v-text-field
ref="reference_wavelength"
type="number"
label="Reference Wavelength"
v-model.number="reference_wavelength"
:suffix="dataset_spectral_unit.replace('Angstrom', 'A')"
hint="Rest wavelength of the line of interest"
persistent-hint
:rules="[() => reference_wavelength !== '' || 'This field is required',
() => reference_wavelength >=0 || 'Wavelength must be positive']"
() => reference_wavelength > 0 || 'Wavelength must be positive']"
></v-text-field>
</v-col>
<v-col cols="3" justify="left">{{dataset_spectral_unit}}</v-col>
</v-row>
</v-div>
</v-row>
</div>

<plugin-add-results
:label.sync="results_label"
Expand Down