-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logos and display in carousel #452
Conversation
emblaRoot?.forEach((root) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there are 2 carousels on the same, page, the JavaScript has been updated so that separate options may be set for each one. Although the align
option should always be start to ensure the carousel begins with the first slide that we set. Currently, the options for both carousels are the same but adding this flexibility now will make it easier if we want to make changes.
{{ end }} | ||
{{ end }} | ||
</ul> | ||
<div class="embla overflow-hidden" data-loop="true" data-scroll="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user scrolls through the logos, only 1 moves at a time. We can change this to another number. Also, the user will be able to loop through all of the logos. This means that when the user gets to the last logo they will see the first one. This matches how we handle the testimonials.
{{ end }} | ||
</ul> | ||
</div> | ||
<div class="flex justify-between lg:justify-center gap-x-8 items-center mt-4 p-2 sm:p-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Displaying on the side of the logos, instead of below them, led to issues where the styles were blocked. I couldn't figure out how to prevent that, so they will appear below the logos for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so slick!!
This PR adds more client logos and displays them in a carousel on the home page.
https://www.awesomescreenshot.com/video/36202864?key=917496caf4e8c46fa64dd909930c659b