Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logos and display in carousel #452

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Add logos and display in carousel #452

merged 3 commits into from
Feb 4, 2025

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Jan 31, 2025

This PR adds more client logos and displays them in a carousel on the home page.

https://www.awesomescreenshot.com/video/36202864?key=917496caf4e8c46fa64dd909930c659b

emblaRoot?.forEach((root) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that there are 2 carousels on the same, page, the JavaScript has been updated so that separate options may be set for each one. Although the align option should always be start to ensure the carousel begins with the first slide that we set. Currently, the options for both carousels are the same but adding this flexibility now will make it easier if we want to make changes.

{{ end }}
{{ end }}
</ul>
<div class="embla overflow-hidden" data-loop="true" data-scroll="1">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user scrolls through the logos, only 1 moves at a time. We can change this to another number. Also, the user will be able to loop through all of the logos. This means that when the user gets to the last logo they will see the first one. This matches how we handle the testimonials.

{{ end }}
</ul>
</div>
<div class="flex justify-between lg:justify-center gap-x-8 items-center mt-4 p-2 sm:p-6">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Displaying on the side of the logos, instead of below them, led to issues where the styles were blocked. I couldn't figure out how to prevent that, so they will appear below the logos for now.

@daniellemaxwell daniellemaxwell marked this pull request as ready for review February 3, 2025 23:13
@rebeccabilbro rebeccabilbro self-requested a review February 4, 2025 19:32
Copy link
Member

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so slick!!

@daniellemaxwell daniellemaxwell merged commit 921b39f into main Feb 4, 2025
1 check passed
@daniellemaxwell daniellemaxwell deleted the sc-29080/logos branch February 4, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants