Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load vanity urls from yaml configmap #4

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Load vanity urls from yaml configmap #4

merged 1 commit into from
Dec 30, 2024

Conversation

bbengfort
Copy link
Contributor

@bbengfort bbengfort commented Dec 30, 2024

Scope of changes

Loads vanity URLs from a config map. This is a simple way of defining what URLs we want loaded -- in the future though we should scan our GitHub repository routinely to find new modules.

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

This PR will be merged without review.

Definition of Done

  • I have manually tested the change running it locally (having rebuilt all containers) or via unit tests
  • I have added unit and/or integration tests that cover my changes
  • I have added new test fixtures as needed to support added tests
  • I have updated the dependencies list if necessary (including updating yarn.lock and/or go.sum)

@bbengfort bbengfort merged commit e250d11 into main Dec 30, 2024
5 checks passed
@bbengfort bbengfort deleted the configmap branch December 30, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant