Drop RCMAIL_VERSION < v1.2 check

roundcube · Apr 20, 2024 · d66380f · d66380f
1 parent ee7f798
commit d66380f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -16,4 +16,4 @@ parameters:
         -
             message: '~^Constant RCMAIL_VERSION not found\.$~'
             path: 'src/ExtensionInstaller.php'
-            count: 3
+            count: 1
diff --git a/src/ExtensionInstaller.php b/src/ExtensionInstaller.php
@@ -108,12 +108,7 @@ public function install(InstalledRepositoryInterface $repo, PackageInterface $pa
                 if ($sqldir = realpath($package_dir . \DIRECTORY_SEPARATOR . $extra['roundcube']['sql-dir'])) {
                     $this->io->write("<info>Running database initialization script for {$package_name}</info>");
 
-                    $roundcube_version = self::versionNormalize(RCMAIL_VERSION);
-                    if (self::versionCompare($roundcube_version, '1.2.0', '>=')) {
-                        \rcmail_utils::db_init($sqldir);
-                    } else {
-                        throw new \Exception('Database initialization failed. Roundcube 1.2.0 or above required.');
-                    }
+                    \rcmail_utils::db_init($sqldir);
                 }
             }
 
@@ -178,12 +173,7 @@ public function update(InstalledRepositoryInterface $repo, PackageInterface $ini
                 if ($sqldir = realpath($package_dir . \DIRECTORY_SEPARATOR . $extra['roundcube']['sql-dir'])) {
                     $this->io->write("<info>Updating database schema for {$package_name}</info>");
 
-                    $roundcube_version = self::versionNormalize(RCMAIL_VERSION);
-                    if (self::versionCompare($roundcube_version, '1.2.0', '>=')) {
-                        \rcmail_utils::db_update($sqldir, $package_name);
-                    } else {
-                        throw new \Exception('Database update failed. Roundcube 1.2.0 or above required.');
-                    }
+                    \rcmail_utils::db_update($sqldir, $package_name);
                 }
             }