Data reduction: Send image url instead of image data on search #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces future data usage by a factor of 10 on 100 item paginations Make site useable on slow connections since text is loaded and load when they can. Used cache control to mark the image assets as never changing
gurgalex
force-pushed
the
raw_creature_data
branch
from
14518a0 to
e2c5708
Compare
gurgalex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to reduce duplicate data sent by leveraging the browser's cache facilities.
The bulk of the data sent on pagination is the image data.
with base64 image data
I've updated the database to store the raw png that is now sent out over a custom route
/<id>/images/battle_sprite.pngThe results are stunning
~10x less data sent on every pagination
sending only url
Plus, the cache control I've set (maybe nginx is best for this??) means the images are not rerequested on reloads.
Also, the site is now useable on slow connections since the text is viewable while waiting for images to load.