Bug/fill handle in frozen headers #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add initial header drag preview implementation * Add drag column preview * Rename inner preview widgets * REname dropHeaderAtPosition * Add lines preview * Change mouse curson when hover a selected header * Reorder preview clean up * Fix preview using the latest selection * Render drag preview independet of selections * Fix selection tap initiating header drag * Set header index as a range * Add is header selected method to selection controller * Move action dispatch to methods * Fix preview with frozen panes * Set drop action to move the selection around * Add header cancel drag intent * Move dragging property to its own state class * Rename reorder preview to header drag and drop * Blocks a drop action within the header range * Add header drag state test * Move header drag and drop actions to its own files * Add intent docs * Add drag n drop preview theme * Add docs * Fix format * Add a configuration to swayze scope * Fix test * Fix const warning * Fix typos * Fix some selections no being dragged properly * Add a brief doc on why we use basic cursor for drag * Fix header drag and drop with frozen panes * Move drag state to its own class * Add end boundary drop test * Add header gesture detector tests * Fix dragging overlaping selections * Set a single action mock * Typo * Move drag and drop style to its own class * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Bugfix for fill selection handle, that creates artefacts in frozen rows and columns
Approach
Check if the handle needs to be drawn on both sides of frozen boundary based on range.
Add in the 3 units test for row, column and row + column edges.