Fix crash in completion popup constructor (#532)

royqh1979 · Dec 5, 2024 · b53742c · b53742c
1 parent 8591c23
commit b53742c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/RedPandaIDE/widgets/codecompletionpopup.cpp b/RedPandaIDE/widgets/codecompletionpopup.cpp
@@ -34,7 +34,6 @@ CodeCompletionPopup::CodeCompletionPopup(QWidget *parent) :
     QWidget(parent),
     mMutex()
 {
-    setWindowFlags(Qt::Popup);
     mListView = new CodeCompletionListView(this);
     mModel=new CodeCompletionListModel(&mCompletionStatementList);
     mDelegate = new CodeCompletionListItemDelegate(mModel,this);
@@ -58,6 +57,9 @@ CodeCompletionPopup::CodeCompletionPopup(QWidget *parent) :
 
     mHideSymbolsStartWithTwoUnderline = false;
     mHideSymbolsStartWithUnderline = false;
+
+    // may trigger font change event, place it after member initialization
+    setWindowFlags(Qt::Popup);
 }
 
 CodeCompletionPopup::~CodeCompletionPopup()

diff --git a/RedPandaIDE/widgets/headercompletionpopup.cpp b/RedPandaIDE/widgets/headercompletionpopup.cpp
@@ -29,7 +29,6 @@
 
 HeaderCompletionPopup::HeaderCompletionPopup(QWidget* parent):QWidget(parent)
 {
-    setWindowFlags(Qt::Popup);
     mListView = new CodeCompletionListView(this);
     mModel=new HeaderCompletionListModel(&mCompletionList, 0);
     QItemSelectionModel *m=mListView->selectionModel();
@@ -47,6 +46,9 @@ HeaderCompletionPopup::HeaderCompletionPopup(QWidget* parent):QWidget(parent)
     mCurrentFile = "";
     mPhrase = "";
     mIgnoreCase = false;
+
+    // may trigger font change event, place it after member initialization
+    setWindowFlags(Qt::Popup);
 }
 
 HeaderCompletionPopup::~HeaderCompletionPopup()