Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPAREIRQ_* IRQs #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SPAREIRQ_* IRQs #5

wants to merge 1 commit into from

Conversation

pta2002
Copy link

@pta2002 pta2002 commented Sep 2, 2024

Add spare IRQs to the SVD patch.

I named them SPAREIRQ_IRQ_* instead of SW*_IRQ like in the RP2040 PAC, since in this case they are explicitly named in the datasheet.

(Addresses #4)

Add spare IRQs to the SVD patch.
@9names
Copy link
Member

9names commented Nov 25, 2024

I don't know if we should prefer the name in the rp2350 datasheet over our existing name (in this instance).
RP never bothered to name them for rp2040, and honestly the names they have chosen are clearly auto-generated based on what was sensible during hardware design and aren't as nice for humans.

If we do decide to name them as this PR suggests, I think we should rename them in rp2040-pac for consistency.
Thoughts @jannic @thejpster?

@thejpster
Copy link
Member

I think there's more benefit to rp2350-pac matching rp2040-pac than there is to rp2350-pac matching an obscure part of the datasheet; and the names are pretty obvious anyway.

So I'd vote for changing this PR to use the same names as the rp2040-pac.

@pta2002
Copy link
Author

pta2002 commented Nov 26, 2024

If there's consensus on that I can change this PR to the same names as the rp2040 then. I do agree that if we were to keep a consistent name, it does not make sense to break the rp2040's compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants