Add support for downloadonly in DNF5

[j-mracek]

Resolve: #537

[jan-kolarik]

The PR itself looks great, but I wanted to test the parameter in CLI and it is unknown. I think we are missing the owner.opt_binds().add("downloadonly", downloadonly); in the main config. Can you please fix that?

EDIT: Tested again and it looks OK 🙂

[jrohel]

@jan-kolarik

I think we are missing the owner.opt_binds().add("downloadonly", downloadonly); in the main config. Can you please fix that?

I don't think so. As you can see in the source code, downloadonly is a "runtime only option".
OptionBool downloadonly{false}; // runtime only option

And from my point of view, downloadonly is a specific option of dnf5 application. It is not a libdnf(5) option. Do we want to add this option to the "dnf.conf " file?
The fact that the application option is listed in libdnf (with the note "runtime only option") is strange. Probably from the time when we needed to somehow maintain options between C and Python code. I still tend to separate libdnf library configuration options (applied to each user of the library) and application dnf5 configuration options, which may not be of interest to another application.

[jan-kolarik]

@jan-kolarik

I think we are missing the owner.opt_binds().add("downloadonly", downloadonly); in the main config. Can you please fix that?

I don't think so. As you can see in the source code, downloadonly is a "runtime only option". OptionBool downloadonly{false}; // runtime only option

And from my point of view, downloadonly is a specific option of dnf5 application. It is not a libdnf(5) option. Do we want to add this option to the "dnf.conf " file?

I see. I was confused that the --downloadonly parameter was not recognized for me when testing the PR and I just noticed the binding is missing and it might be the cause. Anyway, I tried to pull the PR again today and everything seems working correctly, so it was just probably my broken local setup.

[j-mracek]

@jan-kolarik

I think we are missing the owner.opt_binds().add("downloadonly", downloadonly); in the main config. Can you please fix that?

I don't think so. As you can see in the source code, downloadonly is a "runtime only option". OptionBool downloadonly{false}; // runtime only option
And from my point of view, downloadonly is a specific option of dnf5 application. It is not a libdnf(5) option. Do we want to add this option to the "dnf.conf " file?

I see. I was confused that the --downloadonly parameter was not recognized for me when testing the PR and I just noticed the binding is missing and it might be the cause. Anyway, I tried to pull the PR again today and everything seems working correctly, so it was just probably my broken local setup.

In the first version I enabled binding to allow --setopt=downloadonly=true but I was not sure whether we want to support that. Be honest I did not found any reason to not add it also.

I think that a binding of the option could be added together with implementation of #555.