Add more dynamic spec test cases

This tests wrong/unknown tags and a doublicated Summary tag
rpm-software-management · Oct 11, 2023 · 6b876e0 · 6b876e0
1 parent 8c02174
commit 6b876e0
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 0 deletions.
diff --git a/tests/data/SPECS/dynamic.spec b/tests/data/SPECS/dynamic.spec
@@ -29,6 +29,13 @@ echo "License: GPL" >> %{specpartsdir}/mainpkg.specpart
 echo "Distribution: RPM test suite." >> %{specpartsdir}/mainpkg.specpart
 echo "URL: http://rpm.org" >> %{specpartsdir}/mainpkg.specpart
 echo "Summary: dynamic hello -- hello, world rpm" >> %{specpartsdir}/mainpkg.specpart
+%{?DOUBLESUMMARY:
+echo "Summary: dynamic hello -- hello, world again" >> %{specpartsdir}/mainpkg.specpart
+}
+%{?WRONGTAG:
+echo "LicenseToKill: True" >> %{specpartsdir}/mainpkg.specpart
+}
+
 }
 
 echo "%package docs" >> %{specpartsdir}/docs.specpart

diff --git a/tests/rpmbuild.at b/tests/rpmbuild.at
@@ -2449,6 +2449,40 @@ error: parsing failed
 
 RPMTEST_CLEANUP
 
+# ------------------------------
+# Check failing dynamic spec generation
+AT_SETUP([rpmbuild with dynamic spec generation fail])
+AT_KEYWORDS([build])
+RPMDB_INIT
+RPMTEST_CHECK([
+
+runroot rpmbuild --quiet -D "FULLDYNAMIC 1" -D "DOUBLESUMMARY 1" -ba /data/SPECS/dynamic.spec
+],
+[0],
+[],
+[warning: line 6: second Summary
+])
+
+RPMTEST_CLEANUP
+
+# ------------------------------
+# Check failing dynamic spec generation
+AT_SETUP([rpmbuild with dynamic spec generation fail])
+AT_KEYWORDS([build])
+RPMDB_INIT
+RPMTEST_CHECK([
+
+runroot rpmbuild --quiet -D "FULLDYNAMIC 1" -D "WRONGTAG 1" -ba /data/SPECS/dynamic.spec
+],
+[1],
+[],
+[error: line 6: Unknown tag: LicenseToKill: True
+error: parsing failed
+])
+
+RPMTEST_CLEANUP
+
+
 # ------------------------------
 # Check source name with space
 AT_SETUP([rpmbuild source name with space])