Skip to content

Commit

Permalink
Eliminate remaining pgpValStr() uses in the codebase
Browse files Browse the repository at this point in the history
These are just rpmpgp.c internal uses but this makes it clearer these
calls in pgpIdentItem() aren't doing anything special with the pgp value
tables, it's just the same dumb algorithm name lookups as the three other
usages in the codebase.

No functional changes.
  • Loading branch information
pmatilai committed Oct 12, 2023
1 parent 4a6114f commit fa81820
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions rpmio/rpmpgp.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,10 @@ char *pgpIdentItem(pgpDigParams digp)
char *signid = rpmhex(pgpDigParamsSignID(digp) + 4, PGP_KEYID_LEN - 4);
rasprintf(&id, _("V%d %s/%s %s, key ID %s"),
pgpDigParamsVersion(digp),
pgpValStr(pgpPubkeyTbl, pgpDigParamsAlgo(digp, PGPVAL_PUBKEYALGO)),
pgpValStr(pgpHashTbl, pgpDigParamsAlgo(digp, PGPVAL_HASHALGO)),
pgpValString(PGPVAL_PUBKEYALGO,
pgpDigParamsAlgo(digp, PGPVAL_PUBKEYALGO)),
pgpValString(PGPVAL_HASHALGO,
pgpDigParamsAlgo(digp, PGPVAL_HASHALGO)),
(pgpSignatureType(digp) == -1) ? "Public Key" : "Signature",
signid);
free(signid);
Expand Down

0 comments on commit fa81820

Please sign in to comment.