Fix regression of mktree not always rebuilding #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d4e808e added cmake caching for mktree so that we don't rebuild the tree on each "make check" invocation. However, this means we can now easily miss some test dependencies being updated since we don't depend on everything, e.g. the data/ dir. To fix this, instead of adding each and every file and directory as a dependency of the mktree.output command, just rebuild the tree every time. The base image (made with DNF) is already cached anyway, and the added overhead is tiny and outweighs the (potential) engineering hours lost due to this. The funny thing is, this was already fixed once in 2019: fc05045 Sometimes you've just gotta fix stuff twice before it sticks! Fixes: rpm-software-management#2725
dmnks
force-pushed
the
always-rebuild-tests
branch
from
757cd17 to
d94a642
Compare
|
This turned out to be a pretty recent regression (commit d4e808e) 😅 |
|
Oh. Yep, I even kinda remember seeing that commit. Didn't ring a bell today though 😆 /me feels silly for not investigating at least that much... I indeed had a feeling that this was a pretty recent thing, but then something like this can go unnoticed for some time. |
|
Nah, no worries. It got buried in the other refactorings in that PR anyway. I also didn't realize this at first even though it's kinda obvious. The timing of you finding this is actually just perfect as it makes the other PR for OCI images that I'm finishing up (for a while now, lol) a little bit simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d4e808e added cmake caching for mktree so that we don't rebuild the tree on each "make check" invocation. However, this means we can now easily miss some test dependencies being updated since we don't depend on everything, e.g. the data/ dir.
To fix this, instead of adding each and every file and directory as a dependency of the mktree.output command, just rebuild the tree every time. The base image (made with DNF) is already cached anyway, and the added overhead is tiny and outweighs the (potential) engineering hours lost due to this.
The funny thing is, this was already fixed once in 2019: fc05045
Sometimes you've just gotta fix stuff twice before it sticks!
Fixes: #2725