Refactor keystore operations to a separate source + internal API #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will be needed to move the keystore backends to a separate file. No functional changes.
Another preparatory step towards splitting the keystore operations into a separate file. No functional changes.
This should've been in commit 4c61c1f already. No functional changes.
Paving way for next steps, no functional changes.
Preparing for next steps, no functional changes.
Paving way for next steps, no functional changes.
Paving way for next steps, no functional changes.
Except for making the three keystore API functions non-static, there are no code changes here, it's all just moving stuff around. Thus, there cannot be any functionality changes either. The internal API here should not be considered final, this is just a stepping stone to hide the keystore internals from the rest of the rpmts layer. Related: rpm-software-management#3342
|
|
|
Otherwise this looks pretty straight forward and good. |
|
Yes, the naming is a mess, but the names are not being introduced here, it's just getting moved around and intentionally preserving as much as possible to make it easier to verify there are no code changes. It'll get cleaned up in the next stage where the keystore is turned into an abstract class with a bunch of different implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in commit messages, but short summary is that this is all just refactoring prep-work for #3342.
The added API of keystore Load, Import and Delete functions sort of achieves the abstraction but this exact API shouldn't be seen as any final state of affairs, it's just a milestone along the road.
This looks big but the actual code changes are rather minimal, on purpose. Once this lands, the next steps will be isolating the header fubar into the rpmdb keystore and making the keystore an actual type (think object) instead of just being ifs around keyringtype number.