Take read-only transaction lock for keyring load #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 364d284 moved a little too much to the keystore side, revert the part that moved keyring type detection back to the rpmts level. No functional changes, needed for the next steps.
Take read-only transaction lock at the rpmts side, pass it down the rpmKeystoreLoad() hatch. Somehow this feels like an overkill but then our keystores haven't been designed with concurrent access in mind *at all*, so play safe and just take a read lock while loading they keystore. It also balances the API: everything just takes a txn item now. Related: rpm-software-management#3342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more refactor before getting to the real #3342 part...