Support Fedora 41 in Dockerfile #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I completely forgot why we added the gdb-headless version range via ea4a98b. Spoiler alert: to support F39. We don't want to drop support for F39 just yet so let me fix this up. |
|
Fixed. |
This is needed for "make check" to work on a Fedora 41 host where the FROM directive is overridden to fedora:41. - Drop the workaround for gdb-headless on F41, it's no longer available there and the bug is fixed on F40+: https://bugzilla.redhat.com/show_bug.cgi?id=2310156 - Don't try to remove rpm-sign-libs and python3-rpm on F41 since dnf5 no longer pulls them in. - Make sure to call "dnf clean all" before "rpm -e" as python3-rpm is needed by dnf4 to function (hence the duplicated call). - Add a comment at the top saying which Fedora versions are supported by the Dockerfile. This could be checked automatically during cmake config but let's leave that for later. - Detect F41 vs. older by looking for the dnf5 binary, it's the easiest way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for "make check" to work on a Fedora 41 host where the FROM directive is overridden to fedora:41.
Drop the workaround for gdb-headless on F41, it's no longer available there and the bug is fixed on F40+: https://bugzilla.redhat.com/show_bug.cgi?id=2310156
Don't try to remove rpm-sign-libs and python3-rpm on F41 since dnf5 no longer pulls them in.
Make sure to call "dnf clean all" before "rpm -e" as python3-rpm is needed by dnf4 to function (hence the duplicated call).
Add a comment at the top saying which Fedora versions are supported by the Dockerfile. This could be checked automatically during cmake config but let's leave that for later.
Detect F41 vs. older by looking for the dnf5 binary, it's the easiest way.