Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another signature verification verbose message update #3432

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

pmatilai
Copy link
Member

@pmatilai pmatilai commented Nov 6, 2024

This adds the following to verbose mode signature verification:

  • OpenPGP string to all signatures (these are not raw DSA/RSA/etc but OpenPGP)
  • Header+payload signatures and digests are now prefixed Legacy to make it clear what they are

Both needed to pave way for the multiple signature stuff.

@pmatilai pmatilai requested a review from a team as a code owner November 6, 2024 12:26
@pmatilai pmatilai requested review from ffesti and removed request for a team November 6, 2024 12:26
This clarifies what these things are - not raw DSA/RSA signatures but
OpenPGP signatures. It also opens the door for other types of signatures
somewhere in the future, even though no such things are in the plans
just now.

Most importantly though, this will be needed to make sense of these
messages with the multiple OpenPGP signature support where we no longer
know such algorithm details.

Related: rpm-software-management#3385
Header+payload signatures and digests are rpm v3 era stuff, we still
process them but let people know what they are.

What a joyous exercise in sed...

Related: rpm-software-management#3385
@pmatilai
Copy link
Member Author

pmatilai commented Nov 7, 2024

Rebased and conflict fixed.

@ffesti ffesti merged commit 56c4414 into rpm-software-management:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants