Fixes + cleanups to rpmkeys manual #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwalfield
reviewed
Nov 7, 2024
|
Thanks for the suggestions @nwalfield , should be sorted now. I also found yet more fubar about the rpm database and headers in there, removed. |
nwalfield
reviewed
Nov 7, 2024
docs/man/rpmkeys.8.md
Outdated
|
|
||
| Finally, public keys can be erased after importing just like packages. | ||
| Here\'s how to remove the Red Hat GPG/DSA key: | ||
| Write the key(s) in an ASCII-armor encoding. |
There was a problem hiding this comment.
Also, "write" seemed lonely now that the context changed, so I replaced it with 'Output'. And, there was another use of 'This blahblah', fixed now 😄
dmnks
approved these changes
Nov 8, 2024
|
One more typo fixup 😄 |
Drop all references to pre-historical Red Hat keys, short key-ids and gpg-pubkey packages. Use the term fingerprint consistently everywhere. Add a brief explanation of the --list format and usage example for --export too.
|
I've autosquashed the fixup commit on top and will merge this once the CI finishes. This is the fixup patch I've applied, just for full transparency: diff --git a/docs/man/rpmkeys.8.md b/docs/man/rpmkeys.8.md
index e7993e52c..093a91606 100644
--- a/docs/man/rpmkeys.8.md
+++ b/docs/man/rpmkeys.8.md
@@ -25,7 +25,7 @@ The general forms of rpm digital signature commands are
**rpmkeys** **\--import** *PUBKEY \...*
-**rpmkeys** **\--delete** \[*FINGERPRINT \...*
+**rpmkeys** **\--delete** *FINGERPRINT \...*
**rpmkeys** {**-K\|\--checksig**} *PACKAGE\_FILE \...*
@@ -53,7 +53,7 @@ The fingerprint is the handle used for all operations on the keys.
Output the key(s) using an ASCII-armor encoding.
-Exporting allows inspectecting the data with specialized tools, such
+Exporting allows for inspecting the data with specialized tools, such
as Sequoia or GnuPG. For example:
**rpmkeys --export 771b18d3d7baa28734333c424344591e1964c5fc | sq inspect ** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop all references to pre-historical Red Hat keys, short key-ids and gpg-pubkey packages. Use the term fingerprint consistently everywhere. Add a brief explanation of the --list format and usage example for --export too.