Support new u! command in sysusers files #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnks
reviewed
Dec 5, 2024
scripts/sysusers.sh
Outdated
| @@ -90,6 +91,10 @@ user() { | |||
| fi | |||
| fi | |||
| fi | |||
|
|
|||
| if [[ $expire ]]; then | |||
| usermod -e 0 "${user}" | |||
There was a problem hiding this comment.
Although various sources claim that both 0 and 1 (or higher) can be used to disable an account, there's at least one place where the use of 0 is discouraged, in the shadow(5) man page:
account expiration date
The date of expiration of the account, expressed as the number of days since Jan 1, 1970 00:00 UTC.
Note that an account expiration differs from a password expiration. In case of an account expiration, the user
shall not be allowed to login. In case of a password expiration, the user is not allowed to login using her
password.
An empty field means that the account will never expire.
The value 0 should not be used as it is interpreted as either an account with no expiration, or as an expiration
on Jan 1, 1970.
So I wonder if using 1 wouldn't be safer? It's also what sysusers does here (albeit still saying that either 0 or 1 can be used, see this line).
There was a problem hiding this comment.
Yeah, let's rather be on the save side. Changed to 1.
systemd 257 defines a new modifier ! for u entries that locks the account by setting it as expired. See systemd/systemd@2ec7977 Resolves: rpm-software-management#3450
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd 257 defines a new modifier ! for u entries that locks the account by setting it as expired.
See systemd/systemd@2ec7977
Resolves: #3450