Fix brp-strip when using regex-unsafe build root #3492
Conversation
|
Do you have an actual example where this goes wrong? Also it is kinda funny you complain about characters not being quoted just to add a unquoted |
We originally noticed this issue because we sometimes have to build "special versions" of our packages that should only be used for temporary workarounds, distributed only to select users. Compared to a "normal" Eventually we noticed that this would trip up
You are absolutely right, though in this case this does not matter, as what is matched will always start with a plain |
|
Looking through our internal history, I actually got the supposed "bug" wrong. It does not cause any issues with some program not being stripped, it causes the "debuginfo" packages to contain stripped debuginfo, because the above command does not correctly filter out the /usr/lib/debug directory when the version contains a |
By default, the build root contains NAME-VERSION-RELEASE.ARCH. Some of these may contain characters that are not taken as plain characters when interpreting a regex, such as "." or "+". This may lead to a situation where files in /usr/lib/debug are stripped, making them useless for debugging. This is because the command to strip debug information interpreted part of the $RPM_BUILD_ROOT as part of a regex. To fix this, first change to the build root directory, and run the find command relative to that directory, ensuring we don't have to make the build root part of the regex. Co-authored-by: Lars Ellenberg <[email protected]>
|
Yeah, that makes a lot more sense. Thanks for the fix! |
By default, the build root contains NAME-VERSION-RELEASE.ARCH. Some of these may contain characters that are not taken as plain characters when interpreting a regex, such as "." or "+".
This may lead to a situation where files in /usr/lib/debug are stripped, making them useless for debugging. This is because the command to strip debug information interpreted part of the $RPM_BUILD_ROOT as part of a regex.
To fix this, first change to the build root directory, and run the find command relative to that directory, ensuring we don't have to make the build root part of the regex.