Consistify and cleanup test-suite setup macros #3535
Merged
+1,135
−1,129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes, we just want to use the RPMTEST_SETUP name for other things and this is necessary to clear the route.
This gives us a nice place to control the test execution centrally, and also looks more consistent since we already have RPMTEST_CLEANUP as a wrapper for AT_CLEANUP. No functional changes though.
No functional change but this will let us differentiate from the old meaning of RPMDB_INIT.
Many of our tests require RPMTEST_INIT to create a writable snapshot, but especially after c17cc69, relatively few require initializing or resetting the rpmdb in the image. Separate the two and explicitly call RPMDB_RESET (renamed from RPMDB_INIT for a clean break) where it is actually needed. The common pattern that emerges is: build several packages at once and then do various things with it. Each of these RPMDB_RESET uses is actually somewhat problematic because whenever it's required there's a chance that previous tests could affect the results. Can't help that just now, but at least we've identified the issue. Besides making the needs and usages clearer, this introduces a nice fat speed boost for the test-suite - on my laptop, from 2m 50s to 2m 20s.
|
Looks good to me. |
|
Nice, this indeed makes the tests needing to reset the rpmdb stand out more so that we can fix them in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in commits but addressing various items from #2773:
Besides making for more consistent names and allowing future consolidation, gives a nice speed boost (from 2m 50s to 2m 20s on my laptop)