rpmte: Move dependencies into an unordered_map #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of requires_ hack to avoid collision with requires keyword. Also the dependencies are looked up by tag anyway. No need for a case statements when we can use a container instead. Related: rpm-software-management#3537 Related: rpm-software-management#3518
pmatilai
reviewed
Jan 27, 2025
| RPMTAG_PROVIDENAME, RPMTAG_SUPPLEMENTNAME, RPMTAG_ENHANCENAME, | ||
| RPMTAG_REQUIRENAME, RPMTAG_RECOMMENDNAME, RPMTAG_SUGGESTNAME, | ||
| RPMTAG_CONFLICTNAME, RPMTAG_OBSOLETENAME, RPMTAG_ORDERNAME | ||
| }) { |
There was a problem hiding this comment.
Don't use code for what you can easily put into a data structure. Here's a nice opportunity to do just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of requires_ hack to avoid collision with requires keyword.
Also the dependencies are looked up by tag anyway. No need for a case statements when we can use a container instead.
Related: #3537
Related: #3518