Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Rails 7.2 #54

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Test on Rails 7.2 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f787c5
Test on Rails 7.2
benlangfeld Sep 6, 2024
1fcf044
Rails 7.2 requires Ruby >= 3.1
benlangfeld Sep 6, 2024
3424826
Deprecation class methods removed in Rails 7.2
benlangfeld Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
strategy:
fail-fast: false
matrix:
gemfile: ['rails_5.2', 'rails_6.0', 'rails_6.1', 'rails_7.0', 'rails_7.1']
gemfile: ['rails_5.2', 'rails_6.0', 'rails_6.1', 'rails_7.0', 'rails_7.1', 'rails_7.2']

ruby: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3']

Expand Down Expand Up @@ -61,6 +61,16 @@ jobs:
gemfile: 'rails_7.1'
- ruby: '2.6'
gemfile: 'rails_7.1'
- ruby: '2.4'
gemfile: 'rails_7.2'
- ruby: '2.5'
gemfile: 'rails_7.2'
- ruby: '2.6'
gemfile: 'rails_7.2'
- ruby: '2.7'
gemfile: 'rails_7.2'
- ruby: '3.0'
gemfile: 'rails_7.2'

env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
Expand Down
5 changes: 5 additions & 0 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,8 @@ appraise 'rails-7.1' do
gem 'activemodel', '~> 7.1.0'
gem 'activesupport', '~> 7.1.0'
end

appraise 'rails-7.2' do
gem 'activemodel', '~> 7.2.0'
gem 'activesupport', '~> 7.2.0'
end
8 changes: 8 additions & 0 deletions gemfiles/rails_7.2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "activemodel", "~> 7.2.0"
gem "activesupport", "~> 7.2.0"

gemspec path: "../"
4 changes: 2 additions & 2 deletions spec/persistence_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ class MockModelNoAllIndex < MockModel
end

describe 'update_attributes!' do
around(:each) { |example| ActiveSupport::Deprecation.silence { example.run } }
around(:each) { |example| ActiveSupport::Deprecation.new.silence { example.run } }

it 'updates the given attributes' do
model.update_attributes!(name: 'Derp', age: 29)
Expand Down Expand Up @@ -331,7 +331,7 @@ class MockModelNoAllIndex < MockModel
end

describe 'update_attributes' do
around(:each) { |example| ActiveSupport::Deprecation.silence { example.run } }
around(:each) { |example| ActiveSupport::Deprecation.new.silence { example.run } }

it 'updates the given attributes' do
model.update_attributes(name: 'Derp', age: 29)
Expand Down