perf: improve blocked and masking logic checks #1536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bb5d890 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JonasBa
commented
Jul 18, 2024
| @@ -340,26 +340,16 @@ export function needMaskingText( | |||
| } else { | |||
| el = node.parentElement; | |||
| } | |||
| try { | |||
There was a problem hiding this comment.
try/catch is an optimization bailout reason in v8. It's unclear exactly why this code is here, but since this is an extremely hot path, we should remove it
JonasBa
force-pushed
the
jb/perf/isblocked
branch
from
d0d211a
to
f56ff04
Compare
JonasBa
commented
Jul 20, 2024
JonasBa
force-pushed
the
jb/perf/isblocked
branch
from
b0aa591
to
45b9973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the masking and block changes from #1271
Related to #1271