Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amp 99342 splitting selectors #1548

Closed

Commits on Oct 18, 2023

  1. perf: only call createHTMLDocument when it is needed

    Kelly Wallach committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    934262f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from amplitude/kwallach/perf-create-document

    perf: only call createHTMLDocument when it is needed
    kwalker3690 authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8eab3c2 View commit details
    Browse the repository at this point in the history
  3. Create popular-spies-fetch.md

    Kelly Wallach authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    9dae066 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2 from amplitude/kwallach/perf-create-document

    Create changeset
    Kelly Wallach authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    fae9ba5 View commit details
    Browse the repository at this point in the history
  5. Apply formatting changes

    kwalker3690 authored and github-actions[bot] committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7e43b85 View commit details
    Browse the repository at this point in the history
  6. feat: skip through inactive periods instead of fast forward

    Jesse Wang authored and Jesse Wang committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    dbc22b9 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #3 from amplitude/skip-inactive-periods

    feat: skip through inactive periods instead of fast forward
    jxiwang authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    605a78d View commit details
    Browse the repository at this point in the history
  8. Apply formatting changes

    jxiwang authored and github-actions[bot] committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    78be9bb View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Update package.json

    Kelly Wallach authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3e5af93 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Updating references to repo and author

    Kelly Wallach committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b5be3a6 View commit details
    Browse the repository at this point in the history
  2. Update changeset config

    Kelly Wallach committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    2de2b45 View commit details
    Browse the repository at this point in the history
  3. Resetting changeset state

    Kelly Wallach committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8cecb09 View commit details
    Browse the repository at this point in the history
  4. Add our changesets

    Kelly Wallach committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    2dd990c View commit details
    Browse the repository at this point in the history
  5. Fix package name

    Kelly Wallach committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    7f0338a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Updating package references and tests

    Kelly Wallach committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a5a7fb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    334ba23 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4 from amplitude/changeset-release/master

    Version Packages (alpha)
    Kelly Wallach authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    97f5d8d View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    c803e02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b202f5e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    bf02ff5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8017f2a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb4509d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5844b67 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    01c42a7 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #5 from amplitude/AMP-100834-rrweb-fixes

    fix(rrweb-snapshot): pass maskInputFn correctly
    lewgordon-amplitude authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    33293b6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b1ca8e3 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #6 from amplitude/changeset-release/master

    Version Packages (alpha)
    lewgordon-amplitude authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ba5958b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    510bd8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec2e864 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ed0f50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0aefe5e View commit details
    Browse the repository at this point in the history
  5. Fix known issues

    dengelke authored and jxiwang committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3983a2f View commit details
    Browse the repository at this point in the history
  6. Run format

    dengelke authored and jxiwang committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3a9af4a View commit details
    Browse the repository at this point in the history
  7. Fix linting errors

    dengelke authored and jxiwang committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e634c9b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    41e0bf0 View commit details
    Browse the repository at this point in the history
  9. Add changeset

    dengelke authored and jxiwang committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9104dc0 View commit details
    Browse the repository at this point in the history
  10. Add ES6 compat

    jxiwang committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b8f9cb2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e8d02c7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    39adcd9 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #8 from amplitude/external-test-2

    fix(rrweb): external function errors should be tagged
    jackson-amplitude authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d5a6553 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    998ede5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge pull request #10 from amplitude/changeset-release/master

    Version Packages (alpha)
    jackson-amplitude authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5d9cc01 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge pull request #9 from amplitude/pr-1401-upstream

    Switch CSS parser to better handle AddHover
    jxiwang authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fa344e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11f6177 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #11 from amplitude/revert-9-pr-1401-upstream

    Revert "Switch CSS parser to better handle AddHover"
    jxiwang authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8109f8f View commit details
    Browse the repository at this point in the history
  4. Fix known issues

    dengelke authored and jxiwang committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a926dd8 View commit details
    Browse the repository at this point in the history
  5. Run format

    dengelke authored and jxiwang committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    99d334a View commit details
    Browse the repository at this point in the history
  6. Fix linting errors

    dengelke authored and jxiwang committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    593220d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6442004 View commit details
    Browse the repository at this point in the history
  8. Add changeset

    dengelke authored and jxiwang committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    942c7ce View commit details
    Browse the repository at this point in the history
  9. Add ES6 compat

    jxiwang committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2cdd9d4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    76d70af View commit details
    Browse the repository at this point in the history
  11. Merge pull request #14 from amplitude/pr-1401-restore

    fix(rrweb): fix CSS parser for AddHover
    jxiwang authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c51ebed View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1fb0a55 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #15 from amplitude/changeset-release/master

    Version Packages (alpha)
    jxiwang authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c879232 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Fix and test for bug rrweb-io#1457 (Uncaught SyntaxError: Regular exp…

    …ression too large)
    
     - see test case which is extracted from a real world css file; the selector regex was able to traverse the curly brace as when looking for quotes, it wasn't taking into account that the start quote could be escaped
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    63d1dd7 View commit details
    Browse the repository at this point in the history
  2. Apply formatting changes

    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d45c841 View commit details
    Browse the repository at this point in the history
  3. Create fair-ducks-clean.md

    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    dc7b283 View commit details
    Browse the repository at this point in the history
  4. Fix @import regex bit which was stopping consumption in the middle of…

    … a url - need to consume quotes.
    
    Thanks [email protected] for reporting and isolating this case
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ecd7f3d View commit details
    Browse the repository at this point in the history
  5. AMP-99342: Changeset clean-up

    jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    25deb6d View commit details
    Browse the repository at this point in the history
  6. We weren't recursing into media queries (or @supports etc.) to rewrit…

    …e hover pseudoclasses
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8e0d43a View commit details
    Browse the repository at this point in the history
  7. The early return meant that the stylesWithHoverClass cache wasn't bei…

    …ng populated if there were no hover selectors on the stylesheet
    
     - not committing the test, but modifying the existing 'add a hover class to a previously processed css string' as follows shows the problem:
    
    --- a/packages/rrweb-snapshot/test/rebuild.test.ts
    +++ b/packages/rrweb-snapshot/test/rebuild.test.ts
    @@ -151,6 +185,7 @@ describe('rebuild', function () {
             path.resolve(__dirname, './css/benchmark.css'),
             'utf8',
           );
    +      cssText = cssText.replace(/:hover/g, '');
    
           const start = process.hrtime();
           addHoverClass(cssText, cache);
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3c3cd01 View commit details
    Browse the repository at this point in the history
  8. Replace min-device-width and similar with min-width as the former…

    … looks out at the browser viewport whereas we need it to look at the replayer iframe viewport
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    22378f5 View commit details
    Browse the repository at this point in the history
  9. Add some tests to show how the hover replacement works against select…

    …or lists. I believe these were failing in a previous version of rrweb as I had some local patches that no longer seem to be needed to handle these cases
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3af0ac9 View commit details
    Browse the repository at this point in the history
  10. Update name of function to reflect that 'addHoverClass' does more tha…

    …n just :hover. I believe this function is only exported for the purposes of use in the tests
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    89b3c17 View commit details
    Browse the repository at this point in the history
  11. Apply formatting changes

    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    bdb47dd View commit details
    Browse the repository at this point in the history
  12. Create rotten-spies-enjoy.md

    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c7dfd53 View commit details
    Browse the repository at this point in the history
  13. Apply formatting changes

    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8143ee1 View commit details
    Browse the repository at this point in the history
  14. Add correct typing on getSelectors

    Juice10 authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d677cec View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a5343b5 View commit details
    Browse the repository at this point in the history
  16. Change rules to be non optional

    Juice10 authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    60c8a1e View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    937a552 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge pull request #17 from amplitude/AMP-99342-Regex-Error-Hoverclas

    fix(rrweb): Fix some css issues with :hover and rewrite max-device-width
    jxiwang authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    bf451d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13b61d0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #18 from amplitude/changeset-release/master

    Version Packages (alpha)
    jxiwang authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3f77ef2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7ea50cb View commit details
    Browse the repository at this point in the history
  5. AMP-99342: Add old changeset

    jxiwang committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    aaee874 View commit details
    Browse the repository at this point in the history
  6. Apply formatting changes

    jxiwang authored and github-actions[bot] committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    54f2367 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #16 from amplitude/AMP-99342-Regex-Error

    Amp 99342 regex error
    jxiwang authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    1b0c58a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a33a95c View commit details
    Browse the repository at this point in the history
  9. Merge pull request #19 from amplitude/changeset-release/master

    Version Packages (alpha)
    jxiwang authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5284067 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. better splitting of selectors

    daibhin authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9eb5ba8 View commit details
    Browse the repository at this point in the history
  2. add changeset

    daibhin authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    66c6fcb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f6c996 View commit details
    Browse the repository at this point in the history
  4. Parsing nesting is hard :(

    eoghanmurray authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    fa80217 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    007b32b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bb28e21 View commit details
    Browse the repository at this point in the history
  7. Revert "Update packages/rrweb-snapshot/test/css.test.ts"

    This reverts commit 80c8fb1.
    eoghanmurray authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d2147e9 View commit details
    Browse the repository at this point in the history
  8. Reinstate 'Add another test as noticed that it's possible to escape s…

    …trings' - I needed to escape the backslash to demonstrate the test case
    eoghanmurray authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    58fe98d View commit details
    Browse the repository at this point in the history
  9. Ensure we are ignoring commas within strings

     - the added test case didn't actually fail before due to some voodoo with `m.replace(/,/g, '\u200C');` which took me ages to figure out.  Anyhow I figure test and refactor is good in case we replace the css library
    eoghanmurray authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e6acc4f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d5a39c7 View commit details
    Browse the repository at this point in the history
  11. Update .changeset/modern-doors-watch.md

    update changeset to reflect more limited effect
    eoghanmurray authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3a9f0bf View commit details
    Browse the repository at this point in the history
  12. Prettier

    eoghanmurray authored and jxiwang committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7eed14f View commit details
    Browse the repository at this point in the history