-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amp 99342 splitting selectors #1548
Commits on Oct 18, 2023
-
perf: only call createHTMLDocument when it is needed
Kelly Wallach committedOct 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 934262f - Browse repository at this point
Copy the full SHA 934262fView commit details -
Merge pull request #1 from amplitude/kwallach/perf-create-document
perf: only call createHTMLDocument when it is needed
Configuration menu - View commit details
-
Copy full SHA for 8eab3c2 - Browse repository at this point
Copy the full SHA 8eab3c2View commit details -
Kelly Wallach authored
Oct 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 9dae066 - Browse repository at this point
Copy the full SHA 9dae066View commit details -
Merge pull request #2 from amplitude/kwallach/perf-create-document
Create changeset
Kelly Wallach authoredOct 18, 2023 Configuration menu - View commit details
-
Copy full SHA for fae9ba5 - Browse repository at this point
Copy the full SHA fae9ba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e43b85 - Browse repository at this point
Copy the full SHA 7e43b85View commit details -
feat: skip through inactive periods instead of fast forward
Jesse Wang authored and Jesse Wang committedOct 18, 2023 Configuration menu - View commit details
-
Copy full SHA for dbc22b9 - Browse repository at this point
Copy the full SHA dbc22b9View commit details -
Merge pull request #3 from amplitude/skip-inactive-periods
feat: skip through inactive periods instead of fast forward
Configuration menu - View commit details
-
Copy full SHA for 605a78d - Browse repository at this point
Copy the full SHA 605a78dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78be9bb - Browse repository at this point
Copy the full SHA 78be9bbView commit details
Commits on Oct 20, 2023
-
Kelly Wallach authored
Oct 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 3e5af93 - Browse repository at this point
Copy the full SHA 3e5af93View commit details
Commits on Oct 23, 2023
-
Updating references to repo and author
Kelly Wallach committedOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for b5be3a6 - Browse repository at this point
Copy the full SHA b5be3a6View commit details -
Kelly Wallach committed
Oct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 2de2b45 - Browse repository at this point
Copy the full SHA 2de2b45View commit details -
Kelly Wallach committed
Oct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 8cecb09 - Browse repository at this point
Copy the full SHA 8cecb09View commit details -
Kelly Wallach committed
Oct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 2dd990c - Browse repository at this point
Copy the full SHA 2dd990cView commit details -
Kelly Wallach committed
Oct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 7f0338a - Browse repository at this point
Copy the full SHA 7f0338aView commit details
Commits on Oct 24, 2023
-
Updating package references and tests
Kelly Wallach committedOct 24, 2023 Configuration menu - View commit details
-
Copy full SHA for a5a7fb7 - Browse repository at this point
Copy the full SHA a5a7fb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 334ba23 - Browse repository at this point
Copy the full SHA 334ba23View commit details -
Merge pull request #4 from amplitude/changeset-release/master
Version Packages (alpha)
Kelly Wallach authoredOct 24, 2023 Configuration menu - View commit details
-
Copy full SHA for 97f5d8d - Browse repository at this point
Copy the full SHA 97f5d8dView commit details
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c803e02 - Browse repository at this point
Copy the full SHA c803e02View commit details -
Configuration menu - View commit details
-
Copy full SHA for b202f5e - Browse repository at this point
Copy the full SHA b202f5eView commit details
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf02ff5 - Browse repository at this point
Copy the full SHA bf02ff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8017f2a - Browse repository at this point
Copy the full SHA 8017f2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb4509d - Browse repository at this point
Copy the full SHA bb4509dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5844b67 - Browse repository at this point
Copy the full SHA 5844b67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01c42a7 - Browse repository at this point
Copy the full SHA 01c42a7View commit details -
Merge pull request #5 from amplitude/AMP-100834-rrweb-fixes
fix(rrweb-snapshot): pass maskInputFn correctly
Configuration menu - View commit details
-
Copy full SHA for 33293b6 - Browse repository at this point
Copy the full SHA 33293b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1ca8e3 - Browse repository at this point
Copy the full SHA b1ca8e3View commit details -
Merge pull request #6 from amplitude/changeset-release/master
Version Packages (alpha)
Configuration menu - View commit details
-
Copy full SHA for ba5958b - Browse repository at this point
Copy the full SHA ba5958bView commit details
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 510bd8f - Browse repository at this point
Copy the full SHA 510bd8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec2e864 - Browse repository at this point
Copy the full SHA ec2e864View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ed0f50 - Browse repository at this point
Copy the full SHA 3ed0f50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aefe5e - Browse repository at this point
Copy the full SHA 0aefe5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3983a2f - Browse repository at this point
Copy the full SHA 3983a2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a9af4a - Browse repository at this point
Copy the full SHA 3a9af4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e634c9b - Browse repository at this point
Copy the full SHA e634c9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41e0bf0 - Browse repository at this point
Copy the full SHA 41e0bf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9104dc0 - Browse repository at this point
Copy the full SHA 9104dc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8f9cb2 - Browse repository at this point
Copy the full SHA b8f9cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8d02c7 - Browse repository at this point
Copy the full SHA e8d02c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39adcd9 - Browse repository at this point
Copy the full SHA 39adcd9View commit details -
Merge pull request #8 from amplitude/external-test-2
fix(rrweb): external function errors should be tagged
Configuration menu - View commit details
-
Copy full SHA for d5a6553 - Browse repository at this point
Copy the full SHA d5a6553View commit details -
Configuration menu - View commit details
-
Copy full SHA for 998ede5 - Browse repository at this point
Copy the full SHA 998ede5View commit details
Commits on Jun 7, 2024
-
Merge pull request #10 from amplitude/changeset-release/master
Version Packages (alpha)
Configuration menu - View commit details
-
Copy full SHA for 5d9cc01 - Browse repository at this point
Copy the full SHA 5d9cc01View commit details
Commits on Jun 10, 2024
-
Merge pull request #9 from amplitude/pr-1401-upstream
Switch CSS parser to better handle AddHover
Configuration menu - View commit details
-
Copy full SHA for fa344e2 - Browse repository at this point
Copy the full SHA fa344e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11f6177 - Browse repository at this point
Copy the full SHA 11f6177View commit details -
Merge pull request #11 from amplitude/revert-9-pr-1401-upstream
Revert "Switch CSS parser to better handle AddHover"
Configuration menu - View commit details
-
Copy full SHA for 8109f8f - Browse repository at this point
Copy the full SHA 8109f8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a926dd8 - Browse repository at this point
Copy the full SHA a926dd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99d334a - Browse repository at this point
Copy the full SHA 99d334aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 593220d - Browse repository at this point
Copy the full SHA 593220dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6442004 - Browse repository at this point
Copy the full SHA 6442004View commit details -
Configuration menu - View commit details
-
Copy full SHA for 942c7ce - Browse repository at this point
Copy the full SHA 942c7ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cdd9d4 - Browse repository at this point
Copy the full SHA 2cdd9d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76d70af - Browse repository at this point
Copy the full SHA 76d70afView commit details -
Merge pull request #14 from amplitude/pr-1401-restore
fix(rrweb): fix CSS parser for AddHover
Configuration menu - View commit details
-
Copy full SHA for c51ebed - Browse repository at this point
Copy the full SHA c51ebedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fb0a55 - Browse repository at this point
Copy the full SHA 1fb0a55View commit details -
Merge pull request #15 from amplitude/changeset-release/master
Version Packages (alpha)
Configuration menu - View commit details
-
Copy full SHA for c879232 - Browse repository at this point
Copy the full SHA c879232View commit details
Commits on Jun 21, 2024
-
Fix and test for bug rrweb-io#1457 (Uncaught SyntaxError: Regular exp…
…ression too large) - see test case which is extracted from a real world css file; the selector regex was able to traverse the curly brace as when looking for quotes, it wasn't taking into account that the start quote could be escaped
Configuration menu - View commit details
-
Copy full SHA for 63d1dd7 - Browse repository at this point
Copy the full SHA 63d1dd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d45c841 - Browse repository at this point
Copy the full SHA d45c841View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc7b283 - Browse repository at this point
Copy the full SHA dc7b283View commit details -
Fix @import regex bit which was stopping consumption in the middle of…
… a url - need to consume quotes. Thanks [email protected] for reporting and isolating this case
Configuration menu - View commit details
-
Copy full SHA for ecd7f3d - Browse repository at this point
Copy the full SHA ecd7f3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25deb6d - Browse repository at this point
Copy the full SHA 25deb6dView commit details -
We weren't recursing into media queries (or @supports etc.) to rewrit…
…e hover pseudoclasses
Configuration menu - View commit details
-
Copy full SHA for 8e0d43a - Browse repository at this point
Copy the full SHA 8e0d43aView commit details -
The early return meant that the stylesWithHoverClass cache wasn't bei…
…ng populated if there were no hover selectors on the stylesheet - not committing the test, but modifying the existing 'add a hover class to a previously processed css string' as follows shows the problem: --- a/packages/rrweb-snapshot/test/rebuild.test.ts +++ b/packages/rrweb-snapshot/test/rebuild.test.ts @@ -151,6 +185,7 @@ describe('rebuild', function () { path.resolve(__dirname, './css/benchmark.css'), 'utf8', ); + cssText = cssText.replace(/:hover/g, ''); const start = process.hrtime(); addHoverClass(cssText, cache);
Configuration menu - View commit details
-
Copy full SHA for 3c3cd01 - Browse repository at this point
Copy the full SHA 3c3cd01View commit details -
Replace
min-device-width
and similar withmin-width
as the former…… looks out at the browser viewport whereas we need it to look at the replayer iframe viewport
Configuration menu - View commit details
-
Copy full SHA for 22378f5 - Browse repository at this point
Copy the full SHA 22378f5View commit details -
Add some tests to show how the hover replacement works against select…
…or lists. I believe these were failing in a previous version of rrweb as I had some local patches that no longer seem to be needed to handle these cases
Configuration menu - View commit details
-
Copy full SHA for 3af0ac9 - Browse repository at this point
Copy the full SHA 3af0ac9View commit details -
Update name of function to reflect that 'addHoverClass' does more tha…
…n just :hover. I believe this function is only exported for the purposes of use in the tests
Configuration menu - View commit details
-
Copy full SHA for 89b3c17 - Browse repository at this point
Copy the full SHA 89b3c17View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdb47dd - Browse repository at this point
Copy the full SHA bdb47ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7dfd53 - Browse repository at this point
Copy the full SHA c7dfd53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8143ee1 - Browse repository at this point
Copy the full SHA 8143ee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d677cec - Browse repository at this point
Copy the full SHA d677cecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5343b5 - Browse repository at this point
Copy the full SHA a5343b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60c8a1e - Browse repository at this point
Copy the full SHA 60c8a1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 937a552 - Browse repository at this point
Copy the full SHA 937a552View commit details
Commits on Jun 24, 2024
-
Merge pull request #17 from amplitude/AMP-99342-Regex-Error-Hoverclas
fix(rrweb): Fix some css issues with :hover and rewrite max-device-width
Configuration menu - View commit details
-
Copy full SHA for bf451d5 - Browse repository at this point
Copy the full SHA bf451d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13b61d0 - Browse repository at this point
Copy the full SHA 13b61d0View commit details -
Merge pull request #18 from amplitude/changeset-release/master
Version Packages (alpha)
Configuration menu - View commit details
-
Copy full SHA for 3f77ef2 - Browse repository at this point
Copy the full SHA 3f77ef2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ea50cb - Browse repository at this point
Copy the full SHA 7ea50cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaee874 - Browse repository at this point
Copy the full SHA aaee874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54f2367 - Browse repository at this point
Copy the full SHA 54f2367View commit details -
Merge pull request #16 from amplitude/AMP-99342-Regex-Error
Amp 99342 regex error
Configuration menu - View commit details
-
Copy full SHA for 1b0c58a - Browse repository at this point
Copy the full SHA 1b0c58aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a33a95c - Browse repository at this point
Copy the full SHA a33a95cView commit details -
Merge pull request #19 from amplitude/changeset-release/master
Version Packages (alpha)
Configuration menu - View commit details
-
Copy full SHA for 5284067 - Browse repository at this point
Copy the full SHA 5284067View commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9eb5ba8 - Browse repository at this point
Copy the full SHA 9eb5ba8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c6fcb - Browse repository at this point
Copy the full SHA 66c6fcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f6c996 - Browse repository at this point
Copy the full SHA 9f6c996View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa80217 - Browse repository at this point
Copy the full SHA fa80217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 007b32b - Browse repository at this point
Copy the full SHA 007b32bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb28e21 - Browse repository at this point
Copy the full SHA bb28e21View commit details -
Revert "Update packages/rrweb-snapshot/test/css.test.ts"
This reverts commit 80c8fb1.
Configuration menu - View commit details
-
Copy full SHA for d2147e9 - Browse repository at this point
Copy the full SHA d2147e9View commit details -
Reinstate 'Add another test as noticed that it's possible to escape s…
…trings' - I needed to escape the backslash to demonstrate the test case
Configuration menu - View commit details
-
Copy full SHA for 58fe98d - Browse repository at this point
Copy the full SHA 58fe98dView commit details -
Ensure we are ignoring commas within strings
- the added test case didn't actually fail before due to some voodoo with `m.replace(/,/g, '\u200C');` which took me ages to figure out. Anyhow I figure test and refactor is good in case we replace the css library
Configuration menu - View commit details
-
Copy full SHA for e6acc4f - Browse repository at this point
Copy the full SHA e6acc4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5a39c7 - Browse repository at this point
Copy the full SHA d5a39c7View commit details -
Update .changeset/modern-doors-watch.md
update changeset to reflect more limited effect
Configuration menu - View commit details
-
Copy full SHA for 3a9f0bf - Browse repository at this point
Copy the full SHA 3a9f0bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eed14f - Browse repository at this point
Copy the full SHA 7eed14fView commit details