Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pr] release version to 0.0.28 #182

Merged
merged 103 commits into from
Dec 5, 2023
Merged

[pr] release version to 0.0.28 #182

merged 103 commits into from
Dec 5, 2023

Conversation

rryqszq4
Copy link
Owner

@rryqszq4 rryqszq4 commented Dec 5, 2023

@joanhey
Merge into branch master.

@joanhey
Copy link
Contributor

joanhey commented Dec 5, 2023

Mege it !!
The tests will pass.

When it's merged it will not run the dev test, and later we can edit these comments.

@joanhey
Copy link
Contributor

joanhey commented Dec 5, 2023

We need to change the badge in the master branch to:

[![Build](https://github.com/rryqszq4/ngx-php/actions/workflows/build.yml/badge.svg?branch=master)](https://github.com/rryqszq4/ngx-php/actions/workflows/build.yml)

Now it's showing for any branch. And the dev need to fail some times, but don't affect the master branch.

@joanhey
Copy link
Contributor

joanhey commented Dec 5, 2023

We can change the badget later, before create the tag for v0.0.28.

@rryqszq4 rryqszq4 merged commit c3eccb0 into master Dec 5, 2023
112 of 113 checks passed
@joanhey
Copy link
Contributor

joanhey commented Dec 5, 2023

We need to change the badget, only in the master branch.

@joanhey
Copy link
Contributor

joanhey commented Dec 5, 2023

It is not necessary, I think that will use the badget from the default branch.
Wait to check it before change it.

@joanhey
Copy link
Contributor

joanhey commented Dec 5, 2023

image

Now it's poiting to a workflow that don't exist.

@joanhey
Copy link
Contributor

joanhey commented Dec 5, 2023

Also change the typo
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants