feat(cc): getBuddyAgents implementation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsarika
approved these changes
Nov 12, 2024
11 tasks
Kesari3008
approved these changes
Nov 12, 2024
| /** | ||
| * Returns the list of buddy agents in the given state and media according to agent profile settings | ||
| * | ||
| * @param {BuddyAgents} data - The data required to fetch buddy agents, including additional agent profile information. |
There was a problem hiding this comment.
In the JSDOC, we should have either examples of how data looks like or talk about what data properties are here itself
| @@ -17,6 +17,9 @@ export const CC_EVENTS = { | |||
| AGENT_STATE_CHANGE: 'AgentStateChange', | |||
| AGENT_STATE_CHANGE_SUCCESS: 'AgentStateChangeSuccess', | |||
| AGENT_STATE_CHANGE_FAILED: 'AgentStateChangeFailed', | |||
| AGENT_BUDDY_AGENTS: 'BuddyAgents', | |||
There was a problem hiding this comment.
Why do we have 2 constants for the same string?
There was a problem hiding this comment.
Just following the convention of One for the event name and one for success event. If the event name changes in the future, it'll just be a small change here in the constants
| }, | ||
| }; | ||
|
|
||
| const buddyAgentsMock = jest |
There was a problem hiding this comment.
It's a spy not mock so please update the name accordingly, also please use toHaveBeenCalledOnceWith instead of toHaveBeenCalledWith in all the places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES SPARK-567680
This pull request addresses
Fetching Buddy Agents
by making the following changes
introducing webex.cc.getBuddyAgents() API
Vidcast: https://app.vidcast.io/share/ae742d0a-126f-4e4c-90f0-0cf596473063
Change Type
The following scenarios where tested
Manually tested in samples page for fetching buddy agents in following scenarios:
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.